Fix docs and comments around optional intrinsics#289
Merged
lattner merged 1 commit intoswiftlang:masterfrom Dec 6, 2015
Merged
Fix docs and comments around optional intrinsics#289lattner merged 1 commit intoswiftlang:masterfrom
lattner merged 1 commit intoswiftlang:masterfrom
Conversation
docs/archive/LangRef.html is flagged as unmaintained, but I didn't see much else about optionals in the docs so why not update it now. `emitPreconditionOptionalHasValue` had the switch logic moved from the standard library to lib/SILGen/SILGenConvert.cpp back in 9c7417e and there's no _preconditionOptionalHasValue intrinsic anymore. Updated the comment in the headers to clarify.
lattner
added a commit
that referenced
this pull request
Dec 6, 2015
Fix docs and comments around optional intrinsics
Contributor
|
Thanks, we should probably just nuke that document though :-) |
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
…3.1.4-merge-master Merge darwin/libdispatch-913.1.4 to master
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
XFAIL Tagged: SR-9252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/archive/LangRef.html is flagged as unmaintained, but I didn't see much else about optionals in the docs so why not update it anyway!
emitPreconditionOptionalHasValuehad the switch logic moved from the standard library to lib/SILGen/SILGenConvert.cpp back in 9c7417e and there's no_preconditionOptionalHasValueintrinsic anymore. Updated the comment in the headers to clarify.