Add support for 32-bit reflection contexts.#3590
Merged
adrian-prantl merged 1 commit intoswiftlang:stable/20210726from Dec 1, 2021
Merged
Add support for 32-bit reflection contexts.#3590adrian-prantl merged 1 commit intoswiftlang:stable/20210726from
adrian-prantl merged 1 commit intoswiftlang:stable/20210726from
Conversation
0aeb79a to
1c7dd1d
Compare
augusto2112
approved these changes
Nov 30, 2021
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeImpl.h
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeImpl.h
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntime.cpp
Outdated
Show resolved
Hide resolved
This patch introduces a wrapper ReflectionContextInterface that encapsulates all traffic to ReflectionContext and abstracts the detail that ReflectionContext is a template that needs to be specialized for a specific pointer width. This fixes various TypeSystemSwiftTypeRef issues when debugging on an arm64_32 Apple Watch. rdar://83959667
1c7dd1d to
b26f763
Compare
Author
|
@swift-ci test |
kastiglione
approved these changes
Nov 30, 2021
kastiglione
left a comment
There was a problem hiding this comment.
Nice!
It's unfortunate there's not a less repetitive way of erasing the pointer width.
Author
|
@swift-ci test |
compnerd
added a commit
to compnerd/llvm-project
that referenced
this pull request
Dec 1, 2021
The change in swiftlang#3590 introduced an undefined pure virtual method but did not mark it as a pure virtual method, resulting in an undefined exported function. The Windows build identified this issue. Patch by Adrian Prantl!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces a wrapper ReflectionContextInterface that
encapsulates all traffic to ReflectionContext and abstracts the
detail that ReflectionContext is a template that needs to be
specialized for a specific pointer width.
This fixes various TypeSystemSwiftTypeRef issues when debugging on an
arm64_32 Apple Watch.
rdar://83959667