[arm64] Bring this branch in a compilable state.#291
Merged
dcci merged 1 commit intoswiftlang:swift/masterfrom Nov 12, 2019
dcci:halber-mensch
Merged
[arm64] Bring this branch in a compilable state.#291dcci merged 1 commit intoswiftlang:swift/masterfrom dcci:halber-mensch
dcci merged 1 commit intoswiftlang:swift/masterfrom
dcci:halber-mensch
Conversation
Member
Author
|
@swift-ci test and merge |
Member
Author
|
@swift-ci test |
|
This looks like 72105b9 (Fix compilation error in ObjectFileMachO::ParseSymtab)? I think this is fine, though I guess apple/stable/20190619 would have been the canonical cherry-pick target. |
Member
Author
|
That code doesn't exist on the dated branch as it predates the refactor. Hence the fix only on |
swift-ci
pushed a commit
that referenced
this pull request
Aug 3, 2021
…shifted
Add a comment when there is a shifted value,
add x9, x0, #291, lsl #12 ; =1191936
but not when the immediate value is unshifted,
subs x9, x0, #256 ; =256
when the comment adds nothing additional to the reader.
Differential Revision: https://reviews.llvm.org/D107196
jasonmolenda
added a commit
that referenced
this pull request
Aug 10, 2021
…shifted
Add a comment when there is a shifted value,
add x9, x0, #291, lsl #12 ; =1191936
but not when the immediate value is unshifted,
subs x9, x0, #256 ; =256
when the comment adds nothing additional to the reader.
Differential Revision: https://reviews.llvm.org/D107196
(cherry picked from commit 0d8cd4e)
jasonmolenda
added a commit
that referenced
this pull request
Aug 10, 2021
…shifted
Add a comment when there is a shifted value,
add x9, x0, #291, lsl #12 ; =1191936
but not when the immediate value is unshifted,
subs x9, x0, #256 ; =256
when the comment adds nothing additional to the reader.
Differential Revision: https://reviews.llvm.org/D107196
(cherry picked from commit 0d8cd4e)
jasonmolenda
added a commit
that referenced
this pull request
Aug 24, 2021
…shifted
Add a comment when there is a shifted value,
add x9, x0, #291, lsl #12 ; =1191936
but not when the immediate value is unshifted,
subs x9, x0, #256 ; =256
when the comment adds nothing additional to the reader.
Differential Revision: https://reviews.llvm.org/D107196
(cherry picked from commit 0d8cd4e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.