Remove WORKSPACE files and updated Bazel build#1564
Merged
martin4861 merged 2 commits intomasterfrom Mar 10, 2026
Merged
Conversation
|
sbmueller
reviewed
Mar 10, 2026
sbmueller
approved these changes
Mar 10, 2026
Contributor
sbmueller
left a comment
There was a problem hiding this comment.
Do we need more extensive tests with a toolchain udpate than CI? Otherwise LGTM.
Contributor
Author
It should be fine. Apart from clang20 we also use a set of other compilers, therefore the compiler test coverage is good enough. |
Merged
martin4861
added a commit
that referenced
this pull request
Mar 10, 2026
# Description bazel mod strictly requires a version for downstream integration. This was falsely removed in #1564. # API compatibility Yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After migration to bazel_mod, remove the WORKSPACE file. Also updating the LLVM version of the Bazel build.
API compatibility
Yes