Update NodeJS + Haskell version by RReichert · Pull Request #1470 · swift-nav/libsbp

RReichert · 2025-02-03T09:48:05Z

Description

Fix the docker build

See: https://github.com/swift-nav/docker-recipes/pull/439

API compatibility

No compatibility issues

API compatibility plan

N/A

sbmueller · 2025-02-03T17:10:03Z

 RUN \
  if [ "$(ls /tmp)" ]; then ls /tmp; false; fi \
-  && stack install --resolver lts-10.10 sbp \
+  && stack install --resolver lts-23.7 sbp \


Hey, I think I tried it like this in the past, but it didn't work. I remember you did it like this previously. Can you double-check?

From what I understand, the Dockerfile explicitly states what version it wants to use to build the SBP version, where as in the Haskell test build it uses whatever is in that haskell/stack.yaml file. I don't know why there is a difference there.

I've since reverted this change and tried to unify the Haskell version to lts-14.9

RReichert · 2025-02-04T02:56:57Z

 RUN \
  if [ "$(ls /tmp)" ]; then ls /tmp; false; fi \
-  && stack install --resolver lts-10.10 sbp \
+  && stack install --resolver lts-14.9 sbp \


keeping the same version as Haskell build stage

libsbp/haskell/stack.yaml

Line 1 in 9daf121

resolver: lts-14.9

we currently need a version that is greater than v12

RReichert · 2025-02-04T05:23:27Z

-        warnings.simplefilter("always")
-        # Check for warnings.
-        assert len(w) == 1
-        assert issubclass(w[0].category, RuntimeWarning)
-        assert str(w[0].message).startswith('Bad message parsing for line')


This is a strange test and is dependent on the internal implementation of the python JSON library. I've removed it since its not really testing anything important

RReichert · 2025-02-04T10:59:31Z

Needed to regenerated the nodejs list of packages, the old versions were unsupported with the latest LTS

RReichert · 2025-02-04T11:19:22Z

+    "assert": "^2.1.0",
    "binary-parser": "^1.7.0",
    "cuint": "^0.2.2",
    "js-yaml": "^3.13.1",
-    "node-int64": "^0.4.0"
+    "node-int64": "^0.4.0",
+    "path": "^0.12.7",
+    "stream": "^0.0.3"


new packages were required to generate javascript/sbp.bundle.js

sonarqubecloud · 2025-02-05T11:53:45Z

Quality Gate passed for 'libsbp-c'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

RReichert · 2025-02-05T20:53:51Z

 ARG DEBIAN_FRONTEND=noninteractive

-ENV NODE_VERSION=v18.17.0
+ENV NODE_VERSION=v22.13.1


Using the latest NodeJS TLS

RReichert · 2025-02-05T20:55:24Z

      imagemagick \
      enchant \
      clang-format-6.0 \
-      python3.7 python3.7-dev python3.7-distutils \


Python 3.7 is no longer working, the build keep reporting:

Python 3.7 and python 3.8 are now at EOL

RReichert · 2025-02-05T20:57:20Z

      python3 python3-dev python3-distutils \
      python3.9 python3.9-dev python3.9-distutils \
      python3.10 python3.10-dev python3.10-distutils \
+      python3.11 python3.11-dev python3.11-distutils \


I've included python 3.11 since its the latest python version that the Ubuntu Focal offers

RReichert · 2025-02-05T20:57:43Z

Needed to regenerate after updating the NodeJS version

RReichert · 2025-02-05T21:02:46Z

-[coverage:run]
-branch = True
-include = sbp/*
-parallel = True
-
-[coverage:report]
-exclude_lines =
-    # Have to re-enable the standard pragma
-    pragma: no cover
-
-    # Don't complain about missing debug-only code:
-    def __repr__
-    if self\.debug
-
-    # Don't complain if non-runnable code isn't run:
-    if 0:
-    if __name__ == .__main__.:
-ignore_errors = True
-
-[coverage:omit]
-omit =
-    tests/*
-    limbo/*
-    data/*


This was the source of a lot of headaches. The python tests would randomly crash because of some internal Python code coverage error, it would normally happen with Python 3.10 builds, but not exclusively:

There is no need for code coverage here, we are looking to run the test cases and see if they work. If we need code coverage, we can add it later with SonarCloud integration.

Maybe someone else from @swift-nav/algint-team can confirm that we don't require coverage right now? That would be my only concern.

sbmueller

No feedback received on python coverage, therefore approving

# Changes After updating the following PRs: * #1470 * swift-nav/docker-recipes#439 I can finally update the docker image here to fix both repositories.

Update NodeJS version

6aa773d

RReichert requested a review from a team as a code owner February 3, 2025 09:48

update

ac1e27b

RReichert changed the title ~~Update NodeJS version~~ Update NodeJS + Haskell version Feb 3, 2025

update

c95d015

sbmueller reviewed Feb 3, 2025

View reviewed changes

RReichert added 3 commits February 4, 2025 07:10

update

2a5985b

update

2290dfa

ypdate

293d1b2

RReichert marked this pull request as draft February 4, 2025 02:40

RReichert commented Feb 4, 2025

View reviewed changes

update

ff39cd4

RReichert commented Feb 4, 2025

View reviewed changes

update

d890d08

RReichert commented Feb 4, 2025

View reviewed changes

update

cc56205

RReichert commented Feb 4, 2025

View reviewed changes

RReichert added 2 commits February 4, 2025 23:50

update

4f83c17

update

12c0be7

RReichert commented Feb 5, 2025

View reviewed changes

Comment thread javascript/sbp.bundle.js

Copy link
Copy Markdown

Contributor Author

RReichert Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to regenerate after updating the NodeJS version

RReichert commented Feb 5, 2025

View reviewed changes

RReichert marked this pull request as ready for review February 5, 2025 21:03

RReichert requested review from a team and sbmueller and removed request for sbmueller February 6, 2025 01:46

sbmueller approved these changes Feb 10, 2025

View reviewed changes

RReichert merged commit 0f4434b into master Feb 10, 2025

RReichert deleted the rodrigor/fix-nodejs-version branch February 10, 2025 10:56

RReichert mentioned this pull request Feb 10, 2025

Update docker image #1471

Merged

RReichert added a commit that referenced this pull request Feb 10, 2025

Update docker image (#1471)

d56864f

# Changes After updating the following PRs: * #1470 * swift-nav/docker-recipes#439 I can finally update the docker image here to fix both repositories.

Conversation

RReichert commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

API compatibility

API compatibility plan

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RReichert Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RReichert Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 5, 2025

Quality Gate passed for 'libsbp-c'

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sbmueller left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RReichert commented Feb 3, 2025 •

edited

Loading

RReichert Feb 4, 2025 •

edited

Loading

RReichert Feb 4, 2025 •

edited

Loading