Skip to content

Conversation

@PBarmby
Copy link
Contributor

@PBarmby PBarmby commented May 13, 2015

Addresses #85. Still a work in progress, so please don't merge yet. Just looking for confirmation that solutions here seem reasonable as far as formatting and content.

PBarmby added 8 commits May 12, 2015 19:17
* upstream/gh-pages:
  regenerating html
  adding ipythonblocks show_color example to fix last FIXME
  Removing redundant challenges and regenerating HTML
  Update 01-numpy.md
  Minor typo: lead -> load
  Update 01-numpy.md
  Fixing typo in N squared
  spelling fix: concatention -> concatenation
  consistent capitalization of Python
  Typo
@PBarmby
Copy link
Contributor Author

PBarmby commented May 17, 2015

@tbekolay @abostroem: This is ready for a look now -- I haven't done the solutions for the command-line section but won't have time to get to that for a while. I can fix small problems in the earlier sections, though, and have addressed all the comments above.

@abostroem
Copy link
Contributor

@PBarmby Thank you so much for putting these together. I want to take some time to read them so I probably won't to commenting/merging for a few more weeks. If @tbekolay has time before then, maybe we can get it done sooner.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to put all outputs in the the output CSS class ~~~{.output}

@abostroem
Copy link
Contributor

Thanks @PBarmby these are a great start!

* upstream/py3k: (29 commits)
  Removing last references to motivational material and regenerating HTML
  Removed references to motivation.md and motivation.html
  Removing support for motivational slideshows
  Removing Legend from required headings
  Cleaning up instructions about committing Markdown and not HTML
  Updating links to issues, template, example
  Typo
  Typo
  Modifying page template so that main title links to home page.
  Small fix to make answers to challenge appear correctly
  Added 'in the notebook'
  Deleted analyze challenge
  Edited formatting
  Removed abbreviated library names
  Added matplotlib.pyplot and matplotlib inline
  Regenerate HTML
  Switched to active verbs
  Regenerate HTML
  Regenerate HTML
  Regenerate HTML
  ...
@PBarmby
Copy link
Contributor Author

PBarmby commented Jul 26, 2015

Sorry to have taken so long in getting back to this. @abostroem, is it useful for me to try and finish this by making the changes you suggested above, or does the switch to Python 3 mean I should start over? Which branch should I submit the PR against?

@abostroem
Copy link
Contributor

@PBarmby Please continue to work on this and submit the PR to the gh-pages branch. Once we have merged it we can update it to Python 3. It should mostly affect the print statements. How does that sound @tbekolay?

I merged a number of outstanding PR. I think it was mostly modifications on to the wording of some of the exercises - but please make sure your solution match the current set of exercises.

Thank you so much for working on this - it is so important for instructors

@PBarmby
Copy link
Contributor Author

PBarmby commented Jul 29, 2015

Closing this as it's replaced by #144.

@PBarmby PBarmby closed this Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants