-
-
Notifications
You must be signed in to change notification settings - Fork 807
Instructor solutions update #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
abostroem
merged 12 commits into
swcarpentry:gh-pages
from
PBarmby:instruct_notes_update
Aug 16, 2015
Merged
Instructor solutions update #144
abostroem
merged 12 commits into
swcarpentry:gh-pages
from
PBarmby:instruct_notes_update
Aug 16, 2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solution, plus some improved explanations for challenges in 05-cond.
instructors.md
Outdated
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use something more descriptive than c as the variable in the loop to demonstrate how we would like our students to program?
Merged
Contributor
|
@PBarmby This looks good to me. 2 minor inline comments and then it's ready to be merged. Thank you so much! |
Contributor
Author
|
Changes done, ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces PR #99. I think all of the changes requested by @abostroem have been made. Since the discussion about where to put the solutions is still ongoing (see lesson-template#267) I haven't done anything about that.
I hope to get to the solutions for 10-cmdline at some point.