Import cleanup #76
Merged
Import cleanup #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
On Thu, Apr 30, 2015 at 07:13:09AM -0700, Trevor Bekolay wrote:
I don't feel so strongly about this. I personally like to avoid the |
It's not necessary in this lesson. In lesson 10, it is used, but with explanation. No such explanation exist in this lesson.
In a Frequently Argued Issues (FAI) section (idea stolen from John Blischak).
As suggested in #61.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion in #61, I added a pointer to why we're not using aliasing in this lesson to the
instructors.mdfile. I put this in a Frequently Argued Issues (FAI) section, which I stole from @jdblischak (thanks for the idea!)In grepping to make sure we're not aliasing imports anywhere in this lesson, I noticed that we do
from ... importin09-errors.md, so I took out that syntax there as well. We still do this in10-supplementary.md, but it's explained there, and supplementary material, so I left it in.