Fixed incorrect line numbers in 08-defensive.md #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line numbers referred to in the normalize_rectangle function of defensive programming were incorrect. My guess is the comment line was added later, and the line numbers were not updated. I corrected "The preconditions on lines 2, 4, and 5 catch invalid inputs:" to be "The preconditions on lines 3, 5, and 6 catch invalid inputs:" and "...we realize that line 10..." to be "...we realize that line 11..." Also added the line numbers for the post-conditions "The post-conditions on lines 17 and 18...". This clarifies to learners which assertions were preconditions and which ones were post-conditions
Fixed incorrect line numbers in 08-defensive.md
Contributor
|
Thanks for the correction! Maybe we should also add the line numbers to the code excerpt? |
zkamvar
pushed a commit
that referenced
this pull request
Apr 21, 2023
Fixed incorrect line numbers in 08-defensive.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the line numbers referred to in the normalize_rectangle function of defensive programming were incorrect. My guess is the comment line was added later, and the line numbers were not updated.
Also added the line numbers for the post-conditions "The post-conditions on lines 17 and 18...". I thought this would clarify to learners which assertions were preconditions and which ones were post-conditions.