Fix issue #329 #337
Merged
Fix issue #329 #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks very much - if this is for instructor training, can you please mail lessons@software-carpentry.org to let us know? We don't have this GitHub ID in our records yet. |
Contributor
Author
|
This isn't for instructor training (I don't know what that is!). I just read through the tutorial to learn, and noticed this as I went. |
Contributor
|
Thank you for working on fixing this exercise! It might be still confusing to people why the values should be positive and integer. I think if you rename it as something like get_total_count and add a sentence in the beginning that these are counts, would make it more clear. |
Contributor
Author
|
Updated! |
Contributor
|
Thanks! |
rgaiacs
pushed a commit
to rgaiacs/swc-python-novice-inflammation
that referenced
this pull request
May 6, 2017
…list Adding link to instructor training workshop template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing issue #329