Skip to content

Conversation

@tcford
Copy link

@tcford tcford commented Feb 11, 2016

As part of SWC teacher training, I (Talitha Ford) created a diagram to help illustrate how loops work. Hope its useful!

@tbekolay
Copy link
Contributor

Hi @tcford, thanks for the PR! A few minor things:

  • I think you forgot to add the image to the commit. Could you put it in the img folder and add it to this PR? Note that we usually prefer SVG diagrams over PNG, so if you happen to have an SVG you can use that instead :)
  • We prefer Markdown syntax over HTML tags. You can include an image in Markdown with ![alt text](link.to.image.svg). Instead of setting the width in the HTML tag, you can change the image itself to be the desired width.

@tcford
Copy link
Author

tcford commented Feb 11, 2016

Sorry @tbekolay,
I have include both .png and .svg images in the fig directory. Im not familiar with svg and can not work out why some of the text in the image is missing.
I have changed the syntax to Markdown, though the image is quite large and might need resizing.
Did the new pull request work?

@gvwilson gvwilson merged commit 715fbf8 into swcarpentry:gh-pages Jun 14, 2016
map0logo pushed a commit to map0logo/python-novice-inflammation that referenced this pull request Oct 28, 2016
Implement counter of errors at tools/check.py output
rgaiacs pushed a commit to rgaiacs/swc-python-novice-inflammation that referenced this pull request May 6, 2017
…h-11

Create welcome episode 00-welcome.md
zkamvar pushed a commit that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants