Skip to content

Conversation

@bjoyce3
Copy link

@bjoyce3 bjoyce3 commented Aug 7, 2015

A small change in 01-numpy.md for finishing instructor training.

Blake Joyce
Instructor training: June 12th, University of Arizona

@abostroem
Copy link
Contributor

@bjoyce3 Thank you for the rewording. There are a number of changes which are not really changes (I think the only change you are making is the very first change). Can you please update this PR to reflect only the intended change?

@bjoyce3
Copy link
Author

bjoyce3 commented Aug 12, 2015

I'd be happy to change my pull request. But I'm a little confused: Are you
asking me to redo the pull request and only change the wording of that one
section, or something else?

I was just adding some wording as a tiny little change, however when I pull
up the markdown file the spacing was off. I deleted the aberrant spacing,
and that is why the other changes showed up.

On Tue, Aug 11, 2015 at 8:49 PM, Azalee Bostroem notifications@github.com
wrote:

@bjoyce3 https://github.com/bjoyce3 Thank you for the rewording. There
are a number of changes which are not really changes (I think the only
change you are making is the very first change). Can you please update this
PR to reflect only the intended change?


Reply to this email directly or view it on GitHub
#147 (comment)
.

@abostroem
Copy link
Contributor

The rewording is fine (you added a sentence correct?). The spacing changes make it harder to see what changes you made. Can you modify this pull request to only be the rewording. If you would like to change the spacing can you please submit that as a separate pull request?

@abostroem
Copy link
Contributor

@bjoyce3 This looks like you deleted the whole file. Do you mind if I close this PR?

@bjoyce3
Copy link
Author

bjoyce3 commented Aug 17, 2015

Not at all. Thank you.

On August 16, 2015, at 16:18, Azalee Bostroem notifications@github.com wrote:

@bjoyce3 This looks like you deleted the whole file. Do you mind if I close this PR?


Reply to this email directly or view it on GitHub.

@abostroem abostroem closed this Oct 10, 2015
statkclee pushed a commit to statkclee/python-novice-inflammation that referenced this pull request Jan 4, 2016
Set fig.path in tools/chunk-options.R to send all plots to fig/
rgaiacs added a commit to rgaiacs/swc-python-novice-inflammation that referenced this pull request May 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants