Improving Python lessons a bit #108
Conversation
|
@narayananr thanks for these changes. The first change modifies a line that I just changed for a different pull request. Can you take a look and let me know what you think? I also just changed this lesson to look at html files rather than csv files since we now keep the csv files in a data directory and students are generally working in the top level directory. The third change is good, but can you change the word csv to html? |
There was a problem hiding this comment.
The code below does not use the "data" directory, so maybe this should say "current" directory, since that's what it does.
|
@QuLogic I don't think it adds anything to the lesson for students to list CSV files in the data directory vs html files in the current directory and I think it adds a layer of complication (because they have to look in a different direction). Is there a reason you prefer the CSV files? |
|
I think you meant to tag @narayananr; I didn't make that change. |
|
Hi I suggested the change because I had the same thought. This lesson http://swcarpentry.github.io/python-novice-inflammation/04-files.html currently, uses glob on "html" files, and few statements after it uses glob Thanks On Thu, Jun 18, 2015 at 1:05 AM, Azalee Bostroem notifications@github.com
|
Update License.md md5sum on tools/check based on 2f4703e
|
Somewhat improved versions of the |
Starting to incorporate Library Carpentry materials
I made two changes. On the lesson "Repeating Actions with Loops", I expanded the example a bit on looping through a string. And on the lesson "Analyzing Data from Multiple Files", the glob example was trying to "glob" the files that were not in student's working directory for the lesson. I changed it so that the "glob" will list of files in the student's working directory.