-
-
Notifications
You must be signed in to change notification settings - Fork 807
Unescape the less than and greater than inequalities #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unescape the less than and greater than inequalities #1
Conversation
|
Good catch - I'll review. |
|
@gvwilson Did you get a chance to review this or does it still need review? |
|
I haven't had a chance to review - could you please? |
|
@gvwilson not sure how to test this. When I run |
|
You can look at the README.md file in your favourite markdown aware viewer, or just browse the files as of my commit right here on GitHub using GitHub's rendering, e.g.: |
|
@peterjc you missed one: |
|
@abostroem you can force make to update everything by doing |
|
@gvwilson any idea why this is like this in the first place? |
|
@aaren Apologies for losing the thread - why what is like what? |
|
@gvwilson yes, why are these html things ( |
a4009e5 to
7020c6a
Compare
|
Rebased and the quote fixed. |
|
I haven't down a grep across all the lessons (I only have a handful cloned locally), but it looks like something went wrong on this lesson only? |
|
Here is the full (?) list of html entities still in the markdown: @peterjc can you fix the defensive programming one as well? As for the others ( |
|
I thought I did all the less-than and greater-than signs, thanks again @aaren. I'm not sure what is best for the times signs - they should look nice in the HTML output at least. |
|
It's almost certainly a side effect of an automatic translator (probably |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to change with this PR? I know it is happening automatically, but could you move it to a different commit?
|
@abostroem the pre-PR version renders incorrectly. Look at |
|
I deliberately committed in the changes to (Personally I don't understand why generated |
Thanks.
Dr. Greg Wilson | gvwilson@software-carpentry.org |
|
This looks good to me. I'll leave it to @abostroem to merge. |
Unescape the less than and greater than inequalities
Revising error type since Python 3.x has changed it.
Fixed incorrect line numbers in 08-defensive.md
refactored 01-06 to match recent live workshops
Update 11-workshop.md
re-formatting overview box
Adding CoC at the very beginning.
…XME in two spots, instead of python-novice-inflammation. Fixed.
_config.yml: no 'mailto' in 'email'
Using template variables everywhere - Fixed error in header.html; missing }
Unescape the less than and greater than inequalities
Revising error type since Python 3.x has changed it.
Fixed incorrect line numbers in 08-defensive.md
This change seems sensible for both reading the input markdown, and the rendering as HTML.
Assuming there is not something in the template which deals with this (and my change is not needed), then I would guess this fix will be needed on all the other recently migrated lessons (and the migration script may need tweaking).
Update: Looking at a few of the other lessons with R and Python (by eye), I did not find any more unescaped inequalities.