Skip to content

refactor(es/fast-lexer): Cleanup for read_identifier#10170

Merged
kdy1 merged 3 commits intomainfrom
kdy1/fp-kwd
Mar 10, 2025
Merged

refactor(es/fast-lexer): Cleanup for read_identifier#10170
kdy1 merged 3 commits intomainfrom
kdy1/fp-kwd

Conversation

@kdy1
Copy link
Copy Markdown
Member

@kdy1 kdy1 commented Mar 10, 2025

Description:

Keyword handling has some low-hanging fruits.

@kdy1 kdy1 added this to the Planned milestone Mar 10, 2025
@kdy1 kdy1 self-assigned this Mar 10, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 10, 2025

⚠️ No Changeset found

Latest commit: c310825

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 10, 2025

CodSpeed Performance Report

Merging #10170 will not alter performance

Comparing kdy1/fp-kwd (c310825) with main (e764df2)

Summary

✅ 152 untouched benchmarks

@kdy1 kdy1 marked this pull request as ready for review March 10, 2025 15:44
@kdy1 kdy1 requested a review from a team as a code owner March 10, 2025 15:44
@kdy1
Copy link
Copy Markdown
Member Author

kdy1 commented Mar 10, 2025

Merging as this makes code cleaner without perf regression

@kdy1 kdy1 changed the title perf(es/fast-lexer): Optimize read_identifier refactor(es/fast-lexer): Cleanup for read_identifier Mar 10, 2025
@kdy1 kdy1 merged commit d97f7b2 into main Mar 10, 2025
@kdy1 kdy1 deleted the kdy1/fp-kwd branch March 10, 2025 15:45
@kdy1 kdy1 modified the milestones: Planned, v1.11.9 Mar 12, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant