⚠️ No Changeset found

Latest commit: 66f3611

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

CodSpeed Performance Report

Merging #10027 will degrade performances by 5.92%

_{Comparing GiveMe-A-Name:fix/emit_warning (66f3611) with main (c75578b)}

Summary

⚡ 2 improvements
❌ 3 regressions
✅ 191 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

According to Handler code, user's plugin can emit error or warning to Emitter by handler. Then try_with_handler would create a pretty_emitter and return Error if handler has errors. pretty_emitter can't handle Ret to add warning.
I can found two way emit diagnostics to TransformOutput

1. define a trait on Ret, and call it in try_with_handler

pub trait DiagnosticEmitter {
     emit(&mut self, d: Diagnostic);
 }

pub fn try_with_handler<F, Ret>(
    cm: Lrc<SourceMap>,
    config: HandlerOpts,
    op: F,
) -> Result<Ret, Error>
where
    Ret: DiagnosticEmitter,
    F: FnOnce(&Handler) -> Result<Ret, Error>,
{  
   let emitter = PrettyEmitter::new(
        cm,
        wr.clone(),
        to_miette_reporter(config.color),
        PrettyEmitterConfig {
            skip_filename: config.skip_filename,
        },
    );
    
    ....... 
    
    for d in emitter.take_diagnostics { 
          ret.emit(d);
    }
}

2. pass diagnostics go though Handler that a global variable.

transformOutput.diagnostic = handler.take_diagnostics();

impl Handler {
  pub fn take_diagnostics(&self) {
      self.emitter.take_diagnositc.
  }
}