This repository was archived by the owner on Nov 1, 2021. It is now read-only.
text-input: fix releasing destroy handlers#1303
Merged
emersion merged 1 commit intoswaywm:masterfrom Oct 12, 2018
Merged
Conversation
emersion
reviewed
Oct 12, 2018
types/wlr_text_input_v3.c
Outdated
|
|
||
| static void wlr_text_input_destroy(struct wlr_text_input_v3 *text_input) { | ||
| wlr_signal_emit_safe(&text_input->events.destroy, text_input); | ||
| if (text_input->focused_surface) { |
Member
There was a problem hiding this comment.
Instead of adding conditions like this, you can always call wl_list_remove, and call wl_list_init when the surface is removed.
b296874 to
7a16b0c
Compare
7a16b0c to
226eedf
Compare
Contributor
Author
|
I found another place where the handler needs to be released in text-input, and I added |
emersion
approved these changes
Oct 12, 2018
Member
|
Thanks! |
xdavidwu
added a commit
to xdavidwu/sway
that referenced
this pull request
Oct 18, 2019
This ports swaywm/wlroots#1203, swaywm/wlroots#1303, swaywm/wlroots#1308, swaywm/wlroots#1759 rootston part to sway.
Leo1003
pushed a commit
to xdavidwu/sway
that referenced
this pull request
Nov 15, 2019
This ports swaywm/wlroots#1203, swaywm/wlroots#1303, swaywm/wlroots#1308, swaywm/wlroots#1759 rootston part to sway.
Leo1003
added a commit
to xdavidwu/sway
that referenced
this pull request
Nov 20, 2019
This ports swaywm/wlroots#1203, swaywm/wlroots#1303, swaywm/wlroots#1308, swaywm/wlroots#1759 rootston part to sway. Co-Authored-By: Leo Chen <leo881003@gmail.com>
Leo1003
added a commit
to xdavidwu/sway
that referenced
this pull request
Nov 20, 2019
This ports swaywm/wlroots#1203, swaywm/wlroots#1303, swaywm/wlroots#1308, swaywm/wlroots#1759 rootston part to sway. Co-Authored-By: Leo Chen <leo881003@gmail.com>
xdavidwu
added a commit
to xdavidwu/sway
that referenced
this pull request
Jan 2, 2020
This ports swaywm/wlroots#1203, swaywm/wlroots#1303, swaywm/wlroots#1308, swaywm/wlroots#1759 rootston part to sway. Co-Authored-By: Leo Chen <leo881003@gmail.com>
xdavidwu
added a commit
to xdavidwu/sway
that referenced
this pull request
Jan 12, 2020
This ports swaywm/wlroots#1203, swaywm/wlroots#1303, swaywm/wlroots#1308, swaywm/wlroots#1759 rootston part to sway. Co-Authored-By: Leo Chen <leo881003@gmail.com>
xdavidwu
added a commit
to xdavidwu/sway
that referenced
this pull request
Jan 21, 2020
This ports swaywm/wlroots#1203, swaywm/wlroots#1303, swaywm/wlroots#1308, swaywm/wlroots#1759 rootston part to sway. Co-Authored-By: Leo Chen <leo881003@gmail.com>
xdavidwu
added a commit
to xdavidwu/sway
that referenced
this pull request
Feb 14, 2020
This ports swaywm/wlroots#1203, swaywm/wlroots#1303, swaywm/wlroots#1308, swaywm/wlroots#1759 rootston part to sway. Co-Authored-By: Leo Chen <leo881003@gmail.com>
xdavidwu
added a commit
to xdavidwu/sway
that referenced
this pull request
Feb 20, 2020
This ports swaywm/wlroots#1203, swaywm/wlroots#1303, swaywm/wlroots#1308, swaywm/wlroots#1759 rootston part to sway. Co-Authored-By: Leo Chen <leo881003@gmail.com>
xdavidwu
added a commit
to xdavidwu/sway
that referenced
this pull request
Feb 27, 2020
This ports swaywm/wlroots#1203, swaywm/wlroots#1303, swaywm/wlroots#1308, swaywm/wlroots#1759 rootston part to sway. Co-Authored-By: Leo Chen <leo881003@gmail.com>
xdavidwu
added a commit
to xdavidwu/sway
that referenced
this pull request
Mar 11, 2020
This ports swaywm/wlroots#1203, swaywm/wlroots#1303, swaywm/wlroots#1308, swaywm/wlroots#1759 rootston part to sway. Co-Authored-By: Leo Chen <leo881003@gmail.com>
Leo1003
added a commit
to xdavidwu/sway
that referenced
this pull request
Mar 24, 2020
This ports swaywm/wlroots#1203, swaywm/wlroots#1303, swaywm/wlroots#1308, swaywm/wlroots#1759 rootston part to sway. Co-Authored-By: Leo Chen <leo881003@gmail.com>
Leo1003
added a commit
to xdavidwu/sway
that referenced
this pull request
Apr 4, 2020
This ports swaywm/wlroots#1203, swaywm/wlroots#1303, swaywm/wlroots#1308, swaywm/wlroots#1759 rootston part to sway. Co-Authored-By: Leo Chen <leo881003@gmail.com>
emersion
pushed a commit
to swaywm/sway
that referenced
this pull request
Apr 4, 2020
This ports swaywm/wlroots#1203, swaywm/wlroots#1303, swaywm/wlroots#1308, swaywm/wlroots#1759 rootston part to sway. Co-Authored-By: Leo Chen <leo881003@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was possible for listeners on text-input objects to be still attached to signals even after the objects were gone, causing crashes depending on the order objects were destroyed. Not after this patch.