text_input: Implement input-method popups by Decodetalkers · Pull Request #7226 · swaywm/sway

Decodetalkers · 2022-10-17T12:15:25Z

May I continue this pr in #5890 ?

q234rty · 2022-10-27T15:44:34Z

I'm not sure but I don't think this currently works at all? i.e. the original PR needs changes after https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3660 .

Decodetalkers · 2022-10-28T01:36:45Z

I'm not sure but I don't think this currently works at all? i.e. the original PR needs changes after https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3660 .

Emm, It seems still works with the wlroots master and sway master, and I also make changes with the suggestion of the maintainer..

q234rty · 2022-10-28T05:53:19Z

@Decodetalkers Does the input popup correctly disappear after you commit some text?

Decodetalkers · 2022-10-28T08:59:19Z

@Decodetalkers Does the input popup correctly disappear after you commit some text?

I cannot understand, what kind of "uncorrect", can you show me a video ? I cannot reproduce anything..

q234rty · 2022-10-28T09:13:03Z

mov-2022-10-28--17-05-11.mp4

Decodetalkers · 2022-10-28T09:19:53Z

mov-2022-10-28--17-05-11.mp4

I see, I reproduced it on foot.. but wezterm do not have such problem.. Interesting..

Decodetalkers · 2022-10-28T09:35:27Z

mov-2022-10-28--17-05-11.mp4

Now it should be fixed

amano-kenji · 2023-01-30T06:30:51Z

Does this show horizontal pop-ups or vertical pop-ups?

q234rty · 2023-01-30T06:55:38Z

Does this show horizontal pop-ups or vertical pop-ups?

@amano-kenji This depends on your IME. The popup is rendered by the IME.

amano-kenji · 2023-02-01T12:32:52Z

Is it going to be merged soon? It sems Hyprland already merged this feature.

sway/input/text_input.c

bl4ckb0ne · 2024-02-19T15:09:41Z

@cherrot open a new issue for this

sway/input/text_input.c

tokyo4j · 2024-02-19T19:52:34Z

I found the position of popups is shifted by the offset requested with xdg_surface.set_window_geometry in Firefox. So I guess the position should be subtracted by that offset.

Maybe my comment here is missed.
Same problem happens when I run GTK_IM_MODULE=wayland gedit (I set GTK_IM_MODULE to ensure GTK doesn't use dbus interface).

I found this problem is not present in sway-im AUR where scene-graph API is not adopted yet.
I'm not familiar with sway codebase, but I guess this is because the position of surface node can be different from that of the view node.
For reference, wlroots sets the offset of surface node here.

Decodetalkers · 2024-02-20T07:08:45Z

I found the position of popups is shifted by the offset requested with xdg_surface.set_window_geometry in Firefox. So I guess the position should be subtracted by that offset.

Maybe my comment here is missed. Same problem happens when I run GTK_IM_MODULE=wayland gedit (I set GTK_IM_MODULE to ensure GTK doesn't use dbus interface).

I found this problem is not present in sway-im AUR where scene-graph API is not adopted yet. I'm not familiar with sway codebase, but I guess this is because the position of surface node can be different from that of the view node. For reference, wlroots sets the offset of surface node here.

ok, thanks

sway/input/text_input.c

emersion · 2024-02-20T09:42:24Z

sway/input/text_input.c

+	struct sway_input_popup *popup;
+	wl_list_for_each(popup, &relay->input_popups, link) {
+		// send_text_input_rectangle is called in this function
+		input_popup_update(popup);


input_popup_update() is a pretty big hammer, it means we'll create/destroy scene nodes every time a keypress is made. But let's keep this as-is for now and leave the optimization for later.

sway/input/text_input.c

emersion · 2024-02-20T09:44:13Z

Alright, I think this is the last round of comments from me!

remove useless line, and code style adjust

Decodetalkers · 2024-02-20T09:48:56Z

Alright, I think this is the last round of comments from me!

Thanks, I have finished it

emersion

Alright, let's go with this then, thanks a lot for your hard work! I think many users will be thankful :P

swaywm/sway#7226 is merged swaywm/sway#6249 looks dead :( also simplified ./overlays

eternal-sorrow · 2024-06-27T03:42:22Z

So, will there be a release anytime soon that includes this? Because the patch was reworked on top of the new rendering system and the new rendering system is not included in the 1.9 release, there is no way currently to have popups on sway 1.9. So I'm stuck with sway 1.8.1 and an old version of this patch.

kennylevinsen · 2024-06-27T10:39:04Z

Non-bugfix sway releases follow wlroots releases.

If you need features newer than the latest release, you can always build sway and wlroots master. There's even recipes and packages for some distros by community members (AUR, Copr, debian/ubuntu repos, etc.).

eternal-sorrow · 2024-06-27T11:09:37Z

So no? Okay then...

GalaxySnail · 2024-06-27T13:31:47Z

There is a patch for sway 1.9 on AUR: https://aur.archlinux.org/packages/sway-im, extracted from commit 0789c12a.

Decodetalkers force-pushed the input-method-popups branch from 243cfc6 to 8c789a9 Compare October 17, 2022 12:17

layercak3 mentioned this pull request Oct 18, 2022

[Wayland] Candidate list for Fcitx5 immediately disappears/flickers in fullscreen windows (text-input-v3) libsdl-org/SDL#5892

Closed

Decodetalkers force-pushed the input-method-popups branch from 8c789a9 to 41f275e Compare October 28, 2022 01:36

Decodetalkers force-pushed the input-method-popups branch from 41f275e to cf04676 Compare October 28, 2022 09:34

Decodetalkers force-pushed the input-method-popups branch 4 times, most recently from bf22658 to 4bd7fbc Compare November 1, 2022 10:18

tadeokondrak mentioned this pull request Nov 23, 2022

Implement input_method_v2 popups #5890

Closed

Decodetalkers force-pushed the input-method-popups branch 4 times, most recently from cba433e to e2a9a60 Compare November 25, 2022 07:20

Riey mentioned this pull request Nov 25, 2022

Improve candidate window Riey/kime#595

Open

5 tasks

Decodetalkers force-pushed the input-method-popups branch from e2a9a60 to bb7100e Compare November 25, 2022 09:36

wengxt mentioned this pull request Dec 15, 2022

gentoo+sway无法在WPS、foot、dingtalk应用中显示输入法候选窗口 fcitx/fcitx5#455

Closed

someoneinjd mentioned this pull request Dec 25, 2022

basic IME supporting iced-rs/iced#1474

Closed

32 tasks

Decodetalkers force-pushed the input-method-popups branch from bb7100e to d1c6e44 Compare January 4, 2023 07:08

q234rty mentioned this pull request Jan 10, 2023

IME popup is blurry under HiDPI hyprwm/Hyprland#1357

Closed

Decodetalkers force-pushed the input-method-popups branch from d1c6e44 to 2942805 Compare February 2, 2023 04:33

emersion reviewed Feb 17, 2024

View reviewed changes

sway/input/text_input.c Outdated Show resolved Hide resolved

emersion reviewed Feb 17, 2024

View reviewed changes

sway/input/text_input.c Outdated Show resolved Hide resolved

Decodetalkers added 2 commits February 17, 2024 22:09

chore: apply the destory scene way suggested

3f4c0af

chore: tidy up the code style

d7ee56e

This comment was marked as off-topic.

Sign in to view

emersion reviewed Feb 19, 2024

View reviewed changes

sway/input/text_input.c Show resolved Hide resolved

Decodetalkers added 2 commits February 20, 2024 09:45

chore: tidy up scene logic and fix position

ed5674e

fix: position adjust with view's geo

259fce7

emersion reviewed Feb 20, 2024

View reviewed changes

sway/input/text_input.c Outdated Show resolved Hide resolved

emersion reviewed Feb 20, 2024

View reviewed changes

sway/input/text_input.c Outdated Show resolved Hide resolved

emersion reviewed Feb 20, 2024

View reviewed changes

sway/input/text_input.c Outdated Show resolved Hide resolved

chore: tidy up code

34fc0d0

remove useless line, and code style adjust

emersion approved these changes Feb 20, 2024

View reviewed changes

emersion merged commit 7c11c46 into swaywm:master Feb 20, 2024

Guanran928 added a commit to Guanran928/flake that referenced this pull request Feb 24, 2024

sway: use latest git version

66d7539

swaywm/sway#7226 is merged swaywm/sway#6249 looks dead :( also simplified ./overlays

tokyo4j mentioned this pull request Mar 10, 2024

IME: support IME popup labwc/labwc#1602

Merged

sam-mccall mentioned this pull request Mar 23, 2024

input-method popups are duplicated on screen, and then crash #8086

Closed

wiwyil2tr mentioned this pull request Apr 28, 2024

Cannot display the input method popups in wayland applications WillPower3309/swayfx#301

Closed

mochaaP mentioned this pull request May 7, 2024

text_input: Implement input-method popups WillPower3309/swayfx#315

Merged

Cryolitia mentioned this pull request May 4, 2025

[OSPP 2025] 改善 Fcitx5 与 Deepin Desktop Environment 的集成 linuxdeepin/summer-ospp#4

Open

Conversation

Decodetalkers commented Oct 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

q234rty commented Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Decodetalkers commented Oct 28, 2022

Uh oh!

q234rty commented Oct 28, 2022

Uh oh!

Decodetalkers commented Oct 28, 2022

Uh oh!

q234rty commented Oct 28, 2022

Uh oh!

Decodetalkers commented Oct 28, 2022

Uh oh!

Decodetalkers commented Oct 28, 2022

Uh oh!

amano-kenji commented Jan 30, 2023

Uh oh!

q234rty commented Jan 30, 2023

Uh oh!

amano-kenji commented Feb 1, 2023

Uh oh!

Uh oh!

Uh oh!

This comment was marked as off-topic.

bl4ckb0ne commented Feb 19, 2024

Uh oh!

Uh oh!

tokyo4j commented Feb 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Decodetalkers commented Feb 20, 2024

Uh oh!

Uh oh!

Uh oh!

emersion Feb 20, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

emersion commented Feb 20, 2024

Uh oh!

Decodetalkers commented Feb 20, 2024

Uh oh!

emersion left a comment

Choose a reason for hiding this comment

Uh oh!

eternal-sorrow commented Jun 27, 2024

Uh oh!

kennylevinsen commented Jun 27, 2024

Uh oh!

eternal-sorrow commented Jun 27, 2024

Uh oh!

GalaxySnail commented Jun 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

20 participants

Decodetalkers commented Oct 17, 2022 •

edited

Loading

q234rty commented Oct 27, 2022 •

edited

Loading

tokyo4j commented Feb 19, 2024 •

edited

Loading