Skip to content

feat(execute): add support for baseURL override#3538

Merged
char0n merged 7 commits intoswagger-api:masterfrom
sauravazad:master
Nov 7, 2024
Merged

feat(execute): add support for baseURL override#3538
char0n merged 7 commits intoswagger-api:masterfrom
sauravazad:master

Conversation

@sauravazad
Copy link
Contributor

@sauravazad sauravazad commented May 27, 2024 •
edited
Loading

#3537

Description

Add support for baseURL in options for performance gains .

Motivation and Context

Issue: #3537

How Has This Been Tested?

Added supporting test case for the scenario.

Screenshots (if appropriate):

Types of changes

  • No code changes (changes to documentation, CI, metadata, etc)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@char0n char0n self-requested a review October 18, 2024 12:21
@char0n char0n self-assigned this Oct 18, 2024
@char0n
Copy link
Contributor

char0n commented Oct 18, 2024

I'll provide code review ASAP.

char0n
char0n approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! We're missing test for execute as well, I'll probably add it now.

char0n
char0n reviewed Nov 7, 2024
View reviewed changes
@char0n char0n changed the title feat: Adding support to pass down resolved baseURL, to avoid repeated computation . Issue: #3537 feat(execute): add support for baseURL override Nov 7, 2024
@char0n char0n merged commit 1e3d882 into swagger-api:master Nov 7, 2024
@char0n char0n mentioned this pull request Nov 7, 2024
Closed
swagger-bot pushed a commit that referenced this pull request Nov 7, 2024
@semantic-release-bot
chore(release): cut the 3.31.0 release [skip ci]
e053486 
# [3.31.0](v3.30.1...v3.31.0) (2024-11-07)

### Features

* **execute:** add support for baseURL override ([#3538](#3538)) ([1e3d882](1e3d882)), closes [#3537](#3537)
@swagger-bot
Copy link
Contributor

swagger-bot commented Nov 7, 2024

🎉 This PR is included in version 3.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@char0n char0n char0n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@char0n char0n

Labels

released type: feature version: 3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sauravazad @char0n @swagger-bot @sauravazadibm