Fix regex injection in asset folder path matching#788
Merged
Conversation
kyoshino
added a commit
that referenced
this pull request
Jun 7, 2026
n-000000
pushed a commit
to n-000000/sveltia-cms
that referenced
this pull request
Jun 9, 2026
n-000000
pushed a commit
to n-000000/sveltia-cms
that referenced
this pull request
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change escapes configured asset folder paths before compiling them into regular expressions. Template placeholders such as
{{slug}}still work as intended, but ordinary path characters like(,+,[,], and.are now treated literally.The patch also replaces
\bwith a path segment boundary lookahead, because\bdoes not correctly represent folder boundaries when a path segment ends with a non-word character.Security note
Repository-controlled asset folder configuration should not be interpreted as arbitrary regular expression syntax during asset path lookup.
Verification