fix: specify file extension when importing#680
Conversation
dummdidumm
left a comment
There was a problem hiding this comment.
Needs a change set otherwise lgtm
|
Ah forgot this repo uses changesets. It was another one of our repos which still has a manual publish step |
|
Changeset added |
|
Same question: When can this be merged? |
|
And why was the breaking change added in a patch release? I have never understood the Svelte team’s versioning strategy across the packages. |
It's called a bug, you clown. |
|
I mean, TypeScript 6 support should not have been introduced in a patch release. |
Bumps `svelte-package`'s deps to support TypeScript 6. Also updates the test fixtures to match TypeScript 6's output. Not sure if we want to keep both TypeScript 5 and 6 expected output and add a matrix to CI 😓 This is the last step before we make TypeScript 6 the minimum in the `version-3` branch EDIT: requires merging sveltejs/svelte-preprocess#680 first, then releasing a new version and bumping `svelte-preprocess` to get the tests passing. --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [ ] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. ### Tests - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [ ] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed. --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
There's one path I forgot to add a file extension to when doing the TypeScript 6 upgrade and that seems to cause the tests to fail in sveltejs/kit#15896
Before submitting the PR, please make sure you do the following
pnpm lint!)Tests
npm testorpnpm test