Skip to content

fix: set input type before spread value#18345

Merged
Rich-Harris merged 6 commits into
sveltejs:mainfrom
jdoughty04:codex/input-type-before-value-spread
May 31, 2026
Merged

fix: set input type before spread value#18345
Rich-Harris merged 6 commits into
sveltejs:mainfrom
jdoughty04:codex/input-type-before-value-spread

Conversation

@jdoughty04

@jdoughty04 jdoughty04 commented May 31, 2026

Copy link
Copy Markdown
Contributor

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Fixes #18332.

When spread props put value before a later type="hidden" on an <input>, set_attributes currently writes the value while the element is still a text input. Browsers sanitize text input values by removing newlines, so the hidden input permanently loses them before type is applied.

This sets an input's type first whenever the same spread update also includes value or __value, so the existing value handling runs with the final input type. The new runtime-browser sample covers both the problematic spread-first order and the already-working type-first order.

Validation:

  • corepack pnpm lint
  • CI=1 corepack pnpm test
  • corepack pnpm vitest run packages/svelte/tests/runtime-browser/test.ts -t input-type-before-value-spread

@changeset-bot

changeset-bot Bot commented May 31, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4e328b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Rich-Harris
Rich-Harris reviewed May 31, 2026
View reviewed changes
Comment thread .changeset/input-type-before-value.md Outdated
Rich-Harris
Rich-Harris approved these changes May 31, 2026
View reviewed changes

@Rich-Harris Rich-Harris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Rich-Harris Rich-Harris merged commit 378bb25 into sveltejs:main May 31, 2026
16 of 17 checks passed
@github-actions github-actions Bot mentioned this pull request May 31, 2026
Merged
Rich-Harris pushed a commit that referenced this pull request Jun 1, 2026
@github-actions
Version Packages (#18346)
3ef761b 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## svelte@5.56.1

### Patch Changes

- fix: error at compile time on duplicate snippet/declaration tag
definitions ([#18351](#18351))

- fix: parse declaration tag contents more robustly
([#18353](#18353))

- fix: correctly transform references to earlier declarators in a
declaration tag (e.g. `{let a = $state(0), b = $derived(a * 2)}`)
([#18348](#18348))

- fix: avoid spurious `state_referenced_locally` warnings for `$derived`
declarations in declaration tags
([#18348](#18348))

- fix: tolerate whitespace before `let`/`const` in declaration tags
([#18348](#18348))

- fix: prevent infinite loop when a tag's expression ends with a
trailing `/` at the end of the input
([#18350](#18350))

- fix: more robust parsing of declaration tags with regards to `type`
([#18330](#18330))

- fix: preserve newlines in spread input values when the `type`
attribute is applied after `value`
([#18345](#18345))

- fix: update `SvelteURLSearchParams` when setting duplicate keys to the
same joined value
([#18336](#18336))

- fix: check references for blockers on server, too
([#18352](#18352))

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Jun 2, 2026
Closed
huskas-2189 added a commit to huskas-2189/Bookmark that referenced this pull request Jun 14, 2026
@huskas-2189
chore(deps): update dependency svelte to v5.56.1 (#82)
6f6fb22 
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [svelte](https://svelte.dev) ([source](https://github.com/sveltejs/svelte/tree/HEAD/packages/svelte)) | [`5.56.0` → `5.56.1`](https://renovatebot.com/diffs/npm/svelte/5.56.0/5.56.1) | ![age](https://developer.mend.io/api/mc/badges/age/npm/svelte/5.56.1?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/svelte/5.56.0/5.56.1?slim=true) |

---

### Release Notes

<details>
<summary>sveltejs/svelte (svelte)</summary>

### [`v5.56.1`](https://github.com/sveltejs/svelte/blob/HEAD/packages/svelte/CHANGELOG.md#5561)

[Compare Source](https://github.com/sveltejs/svelte/compare/svelte@5.56.0...svelte@5.56.1)

##### Patch Changes

- fix: error at compile time on duplicate snippet/declaration tag definitions ([#&#8203;18351](sveltejs/svelte#18351))

- fix: parse declaration tag contents more robustly ([#&#8203;18353](sveltejs/svelte#18353))

- fix: correctly transform references to earlier declarators in a declaration tag (e.g. `{let a = $state(0), b = $derived(a * 2)}`) ([#&#8203;18348](sveltejs/svelte#18348))

- fix: avoid spurious `state_referenced_locally` warnings for `$derived` declarations in declaration tags ([#&#8203;18348](sveltejs/svelte#18348))

- fix: tolerate whitespace before `let`/`const` in declaration tags ([#&#8203;18348](sveltejs/svelte#18348))

- fix: prevent infinite loop when a tag's expression ends with a trailing `/` at the end of the input ([#&#8203;18350](sveltejs/svelte#18350))

- fix: more robust parsing of declaration tags with regards to `type` ([#&#8203;18330](sveltejs/svelte#18330))

- fix: preserve newlines in spread input values when the `type` attribute is applied after `value` ([#&#8203;18345](sveltejs/svelte#18345))

- fix: update `SvelteURLSearchParams` when setting duplicate keys to the same joined value ([#&#8203;18336](sveltejs/svelte#18336))

- fix: check references for blockers on server, too ([#&#8203;18352](sveltejs/svelte#18352))

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled because a matching PR was automerged previously.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xOTUuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE5NS4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119-->

Co-authored-by: huskas-2189 <huskas-2189@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/huskas-2189/Bookmark/pulls/82
huskas-2189 added a commit to huskas-2189/Bookmark that referenced this pull request Jun 19, 2026
@huskas-2189
chore(deps): update dependency svelte to v5.56.1 (#82)
88b4a04 
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [svelte](https://svelte.dev) ([source](https://github.com/sveltejs/svelte/tree/HEAD/packages/svelte)) | [`5.56.0` → `5.56.1`](https://renovatebot.com/diffs/npm/svelte/5.56.0/5.56.1) | ![age](https://developer.mend.io/api/mc/badges/age/npm/svelte/5.56.1?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/svelte/5.56.0/5.56.1?slim=true) |

---

### Release Notes

<details>
<summary>sveltejs/svelte (svelte)</summary>

### [`v5.56.1`](https://github.com/sveltejs/svelte/blob/HEAD/packages/svelte/CHANGELOG.md#5561)

[Compare Source](https://github.com/sveltejs/svelte/compare/svelte@5.56.0...svelte@5.56.1)

##### Patch Changes

- fix: error at compile time on duplicate snippet/declaration tag definitions ([#&#8203;18351](sveltejs/svelte#18351))

- fix: parse declaration tag contents more robustly ([#&#8203;18353](sveltejs/svelte#18353))

- fix: correctly transform references to earlier declarators in a declaration tag (e.g. `{let a = $state(0), b = $derived(a * 2)}`) ([#&#8203;18348](sveltejs/svelte#18348))

- fix: avoid spurious `state_referenced_locally` warnings for `$derived` declarations in declaration tags ([#&#8203;18348](sveltejs/svelte#18348))

- fix: tolerate whitespace before `let`/`const` in declaration tags ([#&#8203;18348](sveltejs/svelte#18348))

- fix: prevent infinite loop when a tag's expression ends with a trailing `/` at the end of the input ([#&#8203;18350](sveltejs/svelte#18350))

- fix: more robust parsing of declaration tags with regards to `type` ([#&#8203;18330](sveltejs/svelte#18330))

- fix: preserve newlines in spread input values when the `type` attribute is applied after `value` ([#&#8203;18345](sveltejs/svelte#18345))

- fix: update `SvelteURLSearchParams` when setting duplicate keys to the same joined value ([#&#8203;18336](sveltejs/svelte#18336))

- fix: check references for blockers on server, too ([#&#8203;18352](sveltejs/svelte#18352))

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled because a matching PR was automerged previously.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xOTUuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE5NS4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119-->

Co-authored-by: huskas-2189 <huskas-2189@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/huskas-2189/Bookmark/pulls/82
huskas-2189 added a commit to huskas-2189/Bookmark that referenced this pull request Jun 19, 2026
@huskas-2189
chore(deps): update dependency svelte to v5.56.1 (#82)
aa91e42 
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [svelte](https://svelte.dev) ([source](https://github.com/sveltejs/svelte/tree/HEAD/packages/svelte)) | [`5.56.0` → `5.56.1`](https://renovatebot.com/diffs/npm/svelte/5.56.0/5.56.1) | ![age](https://developer.mend.io/api/mc/badges/age/npm/svelte/5.56.1?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/svelte/5.56.0/5.56.1?slim=true) |

---

### Release Notes

<details>
<summary>sveltejs/svelte (svelte)</summary>

### [`v5.56.1`](https://github.com/sveltejs/svelte/blob/HEAD/packages/svelte/CHANGELOG.md#5561)

[Compare Source](https://github.com/sveltejs/svelte/compare/svelte@5.56.0...svelte@5.56.1)

##### Patch Changes

- fix: error at compile time on duplicate snippet/declaration tag definitions ([#&#8203;18351](sveltejs/svelte#18351))

- fix: parse declaration tag contents more robustly ([#&#8203;18353](sveltejs/svelte#18353))

- fix: correctly transform references to earlier declarators in a declaration tag (e.g. `{let a = $state(0), b = $derived(a * 2)}`) ([#&#8203;18348](sveltejs/svelte#18348))

- fix: avoid spurious `state_referenced_locally` warnings for `$derived` declarations in declaration tags ([#&#8203;18348](sveltejs/svelte#18348))

- fix: tolerate whitespace before `let`/`const` in declaration tags ([#&#8203;18348](sveltejs/svelte#18348))

- fix: prevent infinite loop when a tag's expression ends with a trailing `/` at the end of the input ([#&#8203;18350](sveltejs/svelte#18350))

- fix: more robust parsing of declaration tags with regards to `type` ([#&#8203;18330](sveltejs/svelte#18330))

- fix: preserve newlines in spread input values when the `type` attribute is applied after `value` ([#&#8203;18345](sveltejs/svelte#18345))

- fix: update `SvelteURLSearchParams` when setting duplicate keys to the same joined value ([#&#8203;18336](sveltejs/svelte#18336))

- fix: check references for blockers on server, too ([#&#8203;18352](sveltejs/svelte#18352))

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled because a matching PR was automerged previously.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xOTUuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE5NS4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119-->

Co-authored-by: huskas-2189 <huskas-2189@noreply.codeberg.org>
Reviewed-on: https://codeberg.org/huskas-2189/Bookmark/pulls/82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

set_attributes doesn't prioritize type before value for input elements, causing newline stripping with spreads

2 participants

@jdoughty04 @Rich-Harris