fix: prevent corrupt batch link state#18296
Closed
dummdidumm wants to merge 1 commit into
Closed
Conversation
It should be theoretically possible to end up in a state where a batch is unlinked, then relinked (via the `if (this.#roots.length > 0)` logic at the end of `#process`), at which point the links would be wrong if we're not nulling out prev/next during unlink. This adds that, though no test because I wasn't able to come up with one.
🦋 Changeset detectedLatest commit: 16511dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Member
|
Variation of this that deletes some code #18298 |
dummdidumm
pushed a commit
that referenced
this pull request
May 27, 2026
alternative to #18296 — no need to make batches relinkable if we only unlink them when we're fully done with them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be theoretically possible to end up in a state where a batch is unlinked, then relinked (via the
if (this.#roots.length > 0)logic at the end of#process), at which point the links would be wrong if we're not nulling out prev/next during unlink.This adds that, though no test because I wasn't able to come up with one.