fix: do not defer unmount; immediately unmount components#16624
Merged
Rich-Harris merged 5 commits intoAug 15, 2025
Conversation
🦋 Changeset detectedLatest commit: 4f5ac21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
jrmajor
reviewed
Aug 15, 2025
Co-authored-by: Jeremiasz Major <jrh.mjr@gmail.com>
Merged
Member
Contributor
Author
Saw the breaking example this morning. Already working on a fix. Edit: Added a follow-up PR #16633 |
This was referenced Aug 16, 2025
Rich-Harris
added a commit
that referenced
this pull request
Aug 18, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Do not defer unmounting of components. Unmount the components immediately. This changes fixes #16618 and brings back pre-async feature lifecycle order.
Tests and linting
pnpm testand lint the project withpnpm lint