Skip to content

generate TS with satisfies#8001

Merged
dummdidumm merged 3 commits intosatisfiesfrom
satisfying-docs
Dec 9, 2022
Merged

generate TS with satisfies#8001
dummdidumm merged 3 commits intosatisfiesfrom
satisfying-docs

Conversation

@Rich-Harris
Copy link
Copy Markdown
Member

@Rich-Harris Rich-Harris commented Dec 8, 2022

would be nice to get this change in as it reduces the need for proxy types. the site won't build though, because (I think) shiki-twoslash is using an older TypeScript and doesn't know how to deal with the newfangled syntax. A cursory glance didn't show me how to fix it so I'm just going to leave this here for a moment

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 8, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: dfd8fbd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris mentioned this pull request Dec 8, 2022
Merged
@benmccann
Copy link
Copy Markdown
Member

benmccann commented Dec 8, 2022

It looks like shiki/twoslash does not bundle typescript, so should just use the version we have. But perhaps we will need to ask @orta to add support for the satisfies keyword?

@orta
Copy link
Copy Markdown

orta commented Dec 9, 2022

I can't see the deploy error messages, but to my knowledge there shouldn't be any issues with twoslash accepting satisfies as a keyword - twoslash doesn't put a constraint on TS I think, so it should just accept whatever version is in the repo

@dummdidumm dummdidumm marked this pull request as ready for review December 9, 2022 12:27
dummdidumm
dummdidumm approved these changes Dec 9, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had nothing to do with Shiki, just some syntax error and then new errors popping up that needed silencing

@dummdidumm dummdidumm merged commit a22fb66 into satisfies Dec 9, 2022
@dummdidumm dummdidumm deleted the satisfying-docs branch December 9, 2022 12:28
Rich-Harris added a commit that referenced this pull request Dec 9, 2022
@benmccann @Rich-Harris
Use satifies operator (#7861)
20ed756 
* Use satifies operator

* generate TS with `satisfies` (#8001)

Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
@0x524c 0x524c mentioned this pull request Dec 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rich-Harris @benmccann @orta @dummdidumm