Skip to content

[fix] encodeURI during prerender#2427

Merged
benmccann merged 1 commit intomasterfrom
prerender-encode
Sep 14, 2021
Merged

[fix] encodeURI during prerender#2427
benmccann merged 1 commit intomasterfrom
prerender-encode

Conversation

@benmccann
Copy link
Member

Fixes #2403

The browser sends an encoded URI. We should pass the same during prerender

I'll leave the test as a todo for now. Prerendering doesn't have tests yet, so we'll need to address that, but that's probably a bigger issue to address separately

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2021

🦋 Changeset detected

Latest commit: a3170fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann merged commit 3ce209f into master Sep 14, 2021
@benmccann benmccann deleted the prerender-encode branch September 14, 2021 22:25
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Sep 19, 2021
* 'master' of https://github.com/sveltejs/kit: (322 commits)
  Version Packages (next) (sveltejs#2438)
  [fix] revert sveltejs#2354 and fix double character decoding a different way (sveltejs#2435)
  chore: update dependencies (sveltejs#2447)
  [docs] add link to envPrefix option in env var FAQ (sveltejs#2445)
  Fix invalid changeset. Thanks GitHub bot :-p
  [feat] use the Vite server options in dev mode (sveltejs#2232)
  [fix] provide valid value for `letter-spacing` CSS property in template (sveltejs#2437)
  [docs] fix typo (sveltejs#2443)
  [fix] add svelte field when packaging (sveltejs#2431)
  Version Packages (next) (sveltejs#2428)
  [chore] update lockfile
  [fix] update to TS 4.4.3 (sveltejs#2432)
  [chore] add links to repository and homepage to package.json (sveltejs#2425)
  docs: use fragment for prefetching link (sveltejs#2429)
  [fix] encodeURI during prerender (sveltejs#2427)
  Version Packages (next) (sveltejs#2420)
  revert change to versioning during release workflow
  chore: update vite-plugin-svelte (sveltejs#2423)
  [chore] expose Body generic to hook functions (sveltejs#2413)
  [feat] adapter-node entryPoint option (sveltejs#2414)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node build fails when using routes with umlauts

1 participant