Skip to content

[chore] convert remaining type aliases#2018

Merged
benmccann merged 4 commits intosveltejs:masterfrom
ignatiusmb:interfaces
Jul 28, 2021
Merged

[chore] convert remaining type aliases#2018
benmccann merged 4 commits intosveltejs:masterfrom
ignatiusmb:interfaces

Conversation

@ignatiusmb
Copy link
Copy Markdown
Member

@ignatiusmb ignatiusmb commented Jul 26, 2021

Convert remaining public type aliases from #2010

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 26, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 36cc4ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann
Copy link
Copy Markdown
Member

benmccann commented Jul 26, 2021

looks like lint is failing on this one

@ignatiusmb
Copy link
Copy Markdown
Member Author

ignatiusmb commented Jul 26, 2021

It doesn't work with JSDoc for some reason, I'll come back tomorrow and try take a look again

@ignatiusmb ignatiusmb marked this pull request as draft July 26, 2021 17:22
@benmccann
Copy link
Copy Markdown
Member

benmccann commented Jul 26, 2021

Cool. Btw, not sure if you have any ideas on #1997. I was a bit stumped on that one (also TypeScript-related)

@ignatiusmb ignatiusmb marked this pull request as ready for review July 27, 2021 15:49
@ignatiusmb
Copy link
Copy Markdown
Member Author

ignatiusmb commented Jul 27, 2021 •
edited
Loading

It looks like JSDoc parser isn't as advanced as using TypeScript directly (who would've thought), resulting in some losses of its inferencing ability, most likely on the complex and nested types. Filling in the default values seems to do the trick.

benmccann
benmccann reviewed Jul 27, 2021
View reviewed changes
@benmccann benmccann merged commit e23ae18 into sveltejs:master Jul 28, 2021
@ignatiusmb ignatiusmb deleted the interfaces branch July 28, 2021 02:24
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Jul 31, 2021
@sidharthv96
Merge branch 'master' of https://github.com/sveltejs/kit into fix/bas…
d1179e2 
…ePath

* 'master' of https://github.com/sveltejs/kit: (85 commits)
  [chore] minor simplification of `parse_body` (sveltejs#2043)
  Version Packages (next) (sveltejs#2026)
  [chore] deduplicate config types (sveltejs#2030)
  [chore] remove invalid css declaration (sveltejs#2038)
  [fix] correctly pass Vite options in preview mode (sveltejs#2036)
  [feat] Ignore adapter build files (sveltejs#1924)
  [chore] Upgrade Rollup
  Don't check external links on prerender (sveltejs#1679)
  Version Packages (next) (sveltejs#2017)
  [chore] convert remaining type aliases (sveltejs#2018)
  [feat] explicitly set compilerOptions.hydratable to config.kit.hydrate (sveltejs#2024)
  [feat] More powerful and configurable rendering options (sveltejs#2008)
  [chore] typecheck example (sveltejs#2019)
  Change config `prerender.force` to `prerender.onError` (sveltejs#2007)
  [chore] prefer interfaces to types (sveltejs#2010)
  [docs] minor wording improvement in migration guide (sveltejs#2006)
  [chore] test debugging improvements
  [docs] fix typo (sveltejs#2003)
  [chore] use @ts-expect-error instead of @ts-ignore (sveltejs#1999)
  Version Packages (next) (sveltejs#1996)
  ...
@snyk-bot snyk-bot mentioned this pull request Apr 30, 2023
Open
This was referenced May 7, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benmccann benmccann benmccann left review comments

Assignees

No one assigned

Labels

types / typescript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ignatiusmb @benmccann