feat: use SSE in query.live to avoid weird middleman quirks with normal streamed responses#15957
Merged
Conversation
🦋 Changeset detectedLatest commit: ec056c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
Rich-Harris
reviewed
Jun 5, 2026
Rich-Harris
reviewed
Jun 5, 2026
This was referenced Jun 5, 2026
Merged
Rich-Harris
pushed a commit
that referenced
this pull request
Jun 8, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @sveltejs/kit@2.63.1 ### Patch Changes - fix: use SSE for `query.live` ([#15957](#15957)) - fix: use forward slashes in the generated `env.d.ts` import path on Windows ([#15977](#15977)) - fix: allow `$app/environment` with a warning when `explicitEnvironmentVariables` is enabled ([#15980](#15980)) - fix: avoid importing Vite while validating explicit environment variables ([#15953](#15953)) - docs: adjust the release version of explicit env vars ([#15968](#15968)) - fix: ensure `version` is defined when importing from `$app/env` with explicit environment variables ([#15971](#15971)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
|
Don't think this helps with nginx. Just checked the codebase, it has this in the endpoint: return new Response(stream, {
headers: {
'Content-Type': 'text/event-stream',
'Cache-Control': 'no-cache',
'Connection': 'keep-alive',
'X-Accel-Buffering': 'no', // Disable buffering for nginx
},
}); |
Rich-Harris
pushed a commit
that referenced
this pull request
Jun 8, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to version-3, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `version-3` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `version-3`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @sveltejs/kit@3.0.0-next.2 ### Patch Changes - fix: use SSE for `query.live` ([#15957](#15957)) - fix: use forward slashes in the generated `env.d.ts` import path on Windows ([#15977](#15977)) - fix: avoid importing Vite while validating explicit environment variables ([#15953](#15953)) - docs: adjust the release version of explicit env vars ([#15968](#15968)) - fix: ensure `version` is defined when importing from `$app/env` with explicit environment variables ([#15971](#15971)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15956
closes #15921
closes (maybe) #15790?
Some middlemen (antivirus, nginx) do weird buffer-y things with streamed responses, in spite of the no-store cache directives we use. SSE is more universal and seems to bypass some of these behaviors. TBD on whether this works for the nginx issue.
Due to weird GitHub quirks I couldn't push to @IAkumaI's branch. This still contains his commits.