fix: remove Content-Length dependency in binary form deserialization#15796
Merged
elliott-with-the-longest-name-on-github merged 1 commit intoMay 22, 2026
Conversation
Co-authored-by: Copilot <copilot@github.com>
🦋 Changeset detectedLatest commit: a02df9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
LGTM |
Contributor
|
This looks good at first glance, but I need to spend some additional time with it. It's coming very close to the code that solves several published GH Security Advisories / CVEs, and I think it's removing/modifying several of the regression tests for them. I need to make sure we're not opening ourselves up to amplification attacks here. |
Contributor
|
@elliott-with-the-longest-name-on-github not sure on the tests, but the content-length was always a sanity check (easily spoofable), so removing it if it's causing bugs won't be a problem |
elliott-with-the-longest-name-on-github
approved these changes
May 22, 2026
95ca921
into
sveltejs:main
26 checks passed
Merged
Rich-Harris
pushed a commit
that referenced
this pull request
May 22, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @sveltejs/kit@2.61.0 ### Minor Changes - breaking: the `.run()` method has been removed from remote queries on both the client and the server. Use `await query()` directly instead — it now works everywhere ([#15779](#15779)) - feat: remote queries can now be awaited in any context (event handlers, module scope, async callbacks), not just inside reactive contexts. The cache is shared across reactive and non-reactive subscribers, so awaiting a query in an event handler will dedupe with components that have already subscribed to the same query. ([#15779](#15779)) - feat: live query instances are now themselves async-iterable ([#15878](#15878)) - feat: add programmatic `submit` method to `form` remote function instances ([#15657](#15657)) - feat: pass `form` remote function instance into `enhance` callback ([#15657](#15657)) ### Patch Changes - fix: resolve the app payload without using `process.env.NODE_ENV` ([#15852](#15852)) - fix: support `exactOptionalPropertyTypes` for optional route params ([#15825](#15825)) - fix: correctly send `true` value to the server for 'submit' and 'hidden' form fields ([#15858](#15858)) - fix: avoid build warnings about undefined universal hooks ([#15895](#15895)) - fix: prefer default error page when failing to decode the URL pathname ([#15744](#15744)) - fix: disable link prefetching on slow internet connections ([#15885](#15885)) - fix: allow routes ending with optional parameters next to more specific routes ([#15861](#15861)) - fix: remove reliance on Content-Length header in deserialize_binary_form, which caused failures when proxies (e.g. Vercel, Azure) strip the header and use chunked transfer encoding ([#15796](#15796)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15299
closes #15783
This PR removes the reliance on the
Content-Lengthheader indeserialize_binary_form. Proxies and middleboxes (such as Vercel, Azure) may strip theContent-Lengthheader and use chunked transfer encoding instead, which caused the deserialization to throw "invalid Content-Length header".The fix uses the embedded binary header fields (
data_length,file_offsets_length) for validation instead of trustingContent-Length, which can be missing or corrupted by intermediaries.Changes:
Content-Lengthparsing and validation indeserialize_binary_formcontent_length("data overflow", "file offset table overflow", "file data overflow")Content-LengthheaderPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits