feat: return boolean from submit to indicate submission validity#15530
Merged
Conversation
🦋 Changeset detectedLatest commit: 516ea3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
/autofix |
teemingc
reviewed
Mar 10, 2026
Member
|
Do we want to consider returning the submitted data instead of a boolean? #14082 |
Co-authored-by: Tee Ming <chewteeming01@gmail.com>
teemingc
approved these changes
Apr 5, 2026
This was referenced Apr 5, 2026
Merged
6 tasks
elliott-with-the-longest-name-on-github
pushed a commit
that referenced
this pull request
Apr 20, 2026
closes #15700 The enhance function can be (and usually is) async. The return type must therefore not be `void` but `void | Promise<void>` to prevent triggering [`@typescript-eslint/no-misused-promises`](https://typescript-eslint.io/rules/no-misused-promises/) The return type was changed from `void | Promise<void>` to `void` in #15530, which I think was a regression. This PR changes it back. --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. ### Tests - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, a
submitin an enhanced remoteformreturns a boolean indicating whether it was valid or not:The alternative approach we considered was to throw an error on invalid data. But that feels more cumbersome, since now you need to differentiate between different error types:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits