chore: undeprecate config.kit.files.* options#15482
Conversation
🦋 Changeset detectedLatest commit: c8581ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
left a comment
There was a problem hiding this comment.
I think we should keep it hidden from the docs mostly, so that people don't stumble across it too much.
We also said that we wanted to keep it deprecated in the types along with an explanation that this is a "soft deprecation" in the sense of it's still supported but no longer recommended (use monorepos for most use cases instead)
Most importantly we need to revert the deprecation from the options parsing
|
Thanks! I made the changes but I'm unsure about the deprecation wording in the types |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
As discussed during the maintainer's meeting, this PR undeprecates the `kit.files` options. It also reverts the removal of mentions about these options in various parts of the docs done in sveltejs#15343 --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. ### Tests - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed. --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @sveltejs/kit@2.54.0 ### Minor Changes - feat: allow error boundaries to catch errors on the server ([#15308](#15308)) ### Patch Changes - chore: upgrade `devalue` ([#15535](#15535)) - fix: don't wait for remote functions that are not awaited in the template ([#15280](#15280)) - feat: allow `resolve()` to accept pathnames with a search string and/or hash ([#15458](#15458)) - chore: remove deprecation warnings for `config.kit.files.*` options when validating the Svelte config file ([#15482](#15482)) - fix: handles form target attribute in remote form redirects ([#15457](#15457)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@sveltejs/kit](https://svelte.dev) ([source](https://github.com/sveltejs/kit/tree/HEAD/packages/kit)) | [`2.53.4` → `2.55.0`](https://renovatebot.com/diffs/npm/@sveltejs%2fkit/2.53.4/2.55.0) |  |  | --- ### Release Notes <details> <summary>sveltejs/kit (@​sveltejs/kit)</summary> ### [`v2.55.0`](https://github.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#2550) [Compare Source](https://github.com/sveltejs/kit/compare/@sveltejs/kit@2.54.0...@sveltejs/kit@2.55.0) ##### Minor Changes - feat: page and layout params with matchers are now type narrowed in `$app/types`, leading to better type safety when working with params in `$app/types`, `$app/state`, and hooks. ([#​15502](sveltejs/kit#15502)) ### [`v2.54.0`](https://github.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#2540) [Compare Source](https://github.com/sveltejs/kit/compare/@sveltejs/kit@2.53.4...@sveltejs/kit@2.54.0) ##### Minor Changes - feat: allow error boundaries to catch errors on the server ([#​15308](sveltejs/kit#15308)) ##### Patch Changes - chore: upgrade `devalue` ([#​15535](sveltejs/kit#15535)) - fix: don't wait for remote functions that are not awaited in the template ([#​15280](sveltejs/kit#15280)) - feat: allow `resolve()` to accept pathnames with a search string and/or hash ([#​15458](sveltejs/kit#15458)) - chore: remove deprecation warnings for `config.kit.files.*` options when validating the Svelte config file ([#​15482](sveltejs/kit#15482)) - fix: handles form target attribute in remote form redirects ([#​15457](sveltejs/kit#15457)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My44NC4yIiwidXBkYXRlZEluVmVyIjoiNDMuODQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://forgejo.tail5a98.ts.net/gooilers123/monolith/pulls/45
As discussed during the maintainer's meeting, this PR undeprecates the
kit.filesoptions. It also reverts the removal of mentions about these options in various parts of the docs done in #15343Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits