fix: provide correct url info to remote functions#15418
Merged
Conversation
Use `page.state`, which is backed by signals and therefore fork-aware, to provide the correct url info for the remote function request event. This _can_ break if you do the query outside of a reactive context, but that is a more general problem where people have to be careful. Fixes #14921
🦋 Changeset detectedLatest commit: 293a181 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
approved these changes
Feb 25, 2026
Member
|
/ecosystem-ci run |
Merged
Copilot AI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
Use `page.state`, which is backed by signals and therefore fork-aware, to provide the correct url info for the remote function request event. This _can_ break if you do the query outside of a reactive context, but that is a more general problem where people have to be careful. Fixes sveltejs#14921 --------- Co-authored-by: Tee Ming <chewteeming01@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
page.state, which is backed by signals and therefore fork-aware, to provide the correct url info for the remote function request event.This can break if you do the query outside of a reactive context, but that is a more general problem where people have to be careful.
Fixes #14921