feat: provide match function to allow the opposite of resolve#14997
Merged
teemingc merged 24 commits intosveltejs:mainfrom Feb 14, 2026
Merged
feat: provide match function to allow the opposite of resolve#14997teemingc merged 24 commits intosveltejs:mainfrom
teemingc merged 24 commits intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: dc01e8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
IMO this would also need to call the /**
* @param {string | URL} url
*/
export async function match(url) {
if (typeof url === 'string') {
url = new URL(url, location.href);
}
const intent = await get_navigation_intent(url);
if (intent) {
return {
id: intent.id,
params: intent.params
};
}
}On the server this might be a bit more tricky since this logic is scattered over almost 100 lines. |
9e9ab44 to
d02f58d
Compare
Contributor
Author
|
@PatrickG good call. I switched to that and added support for reroute server-side. Probably easiest to leave server as is rather than trying to abstract it away for this one use case? Sorry for not looking at this sooner. |
Contributor
Author
|
I've extracted the route matching into a new |
bd79003 to
2534e43
Compare
PatrickG
reviewed
Dec 12, 2025
PatrickG
reviewed
Dec 12, 2025
PatrickG
reviewed
Dec 12, 2025
teemingc
reviewed
Feb 12, 2026
teemingc
reviewed
Feb 12, 2026
teemingc
reviewed
Feb 12, 2026
teemingc
requested changes
Feb 12, 2026
Member
teemingc
left a comment
There was a problem hiding this comment.
Thank you! Another great contribution 😄 I've left some minor suggestions. I don't think anyone on the team's opposed to this, so it'll probably make it in.
teemingc
reviewed
Feb 12, 2026
teemingc
reviewed
Feb 12, 2026
teemingc
reviewed
Feb 12, 2026
Co-authored-by: Tee Ming <chewteeming01@gmail.com>
teemingc
reviewed
Feb 13, 2026
Merged
Copilot AI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
…js#14997) fixes sveltejs#11746 Delightfully simple to add this as a feature! Couple things I'm not sure of: - The server-side `match` includes endpoints. Is it more confusing to include them or is it better to exclude to maintain parity with client? - `generate:types` doesn't add `match` to `index.d.ts` for some reason. How do I can I get it to work? --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. ### Tests - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed. --------- Co-authored-by: Tee Ming <chewteeming01@gmail.com> Co-authored-by: Patrick <Patrick@ShowYou.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11746
Delightfully simple to add this as a feature!
Couple things I'm not sure of:
matchincludes endpoints. Is it more confusing to include them or is it better to exclude to maintain parity with client?generate:typesdoesn't addmatchtoindex.d.tsfor some reason. How do I can I get it to work?Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits