fix: more robust remote file pattern matching#14578
Merged
Rich-Harris merged 1 commit intomainfrom Oct 2, 2025
Merged
Conversation
Prevents "is this a remote file"-false-negatives which can occur during dev when an ID has a version hash, e.g. `/foo/bar.remote.js?v=123`, which in turn meant the remote file wasn't transformed and the server version ended up on the client
🦋 Changeset detectedLatest commit: 107854d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
Rich-Harris
approved these changes
Oct 2, 2025
Copilot AI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
Prevents "is this a remote file"-false-negatives which can occur during dev when an ID has a version hash, e.g. `/foo/bar.remote.js?v=123`, which in turn meant the remote file wasn't transformed and the server version ended up on the client
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents "is this a remote file"-false-negatives which can occur during dev when an ID has a version hash, e.g.
/foo/bar.remote.js?v=123, which in turn meant the remote file wasn't transformed and the server version ended up on the clientPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.