Merged
Conversation
🦋 Changeset detectedLatest commit: ead1261 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
elliott-with-the-longest-name-on-github
left a comment
There was a problem hiding this comment.
Unfortunate there's no way to test this...
Removed console log for scroll position.
dummdidumm
approved these changes
Sep 30, 2025
Member
dummdidumm
left a comment
There was a problem hiding this comment.
logic looks good, but we should have a comment for this
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Merged
6 tasks
Copilot AI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
* fix: smooth scroll to deep link * remove log Removed console log for scroll position. * Update packages/kit/src/runtime/client/client.js Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a very finicky and hard-to-reproduce (and test for, unfortunately) bug: when navigating to a hash fragment on another page, the captured scroll position is wrong if the page has
scroll-behavior: smooth, because it gets captured at the start of the scroll rather than the end.If my understanding is correct, the buggy sequence of events is:
popstate, or the position of a deep-linked element, or0, 0smoothcase)This PR changes the behaviour slightly: where appropriate, it passes the desired scroll state to
reset_focusso that we end up in the correct place.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits