fix: deserialise streamed custom types#14261
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 23af149 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
golfed it a little bit so that we don't need to repeat the import, by passing a callback to |
Rich-Harris
approved these changes
Aug 20, 2025
Member
Author
Nice! Thanks for that |
Copilot AI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
* add test * add test for single apps * wrap statement in app import * add test for inlined apps * format * changeset * fix lint errors * fix * leaner payloads * fix * tweak --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13428
This PR ensures the
appvariable is available when the server pushes chunks to the client to decode custom data types as they stream in. This fixes streaming for split and single apps by wrapping the code that referencesappafter an import statement, and providing the correct global variable for inline apps.An additional test suite for inline apps has also been added since none existed before. However, feel free to remove it if it's too much just to test inline apps.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits