🦋 Changeset detected

Latest commit: 794b25f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Preview: https://svelte-dev-git-preview-kit-13935-svelte.vercel.app/

The lint error is from eslint which likely trips up on multiple files just with different extensions, best to ignore that directory in the config.
The other error sounds like something from the runtime, but not sure. Maybe NodeJs because the CI runs with a version which doesn't support ts files yet?

ugh, conditionally passing --experimental-strip-types is weird.

changed test-others to a matrix to be able to test with 22 and 18.

In a separate PR we should look into adding node24 to the matrix tests.

I'm not sure it makes sense to support .mjs and .mts file extensions. SvelteKit projects can only be ESM projects in which case you'd never use those extensions

When it was only one exact filename svelte.config.js it made the code simpler not checking svelte.config.mjs too.

Now that this PR adds checking multiple extensions, its very easy to allow mjs and mts and those are valid even in projects where "type":"module" is in package.json. They also enable custom setups where type is commonjs (eg sveltekit app embedded in a node app package).

To me it's nothing about the simplicity of the code, but whether we want to encourage bad practices. There is no reason a SvelteKit project should ever lack "type": "module" or use .mjs/.mts that I can think of

removed mjs and mts, lets see if someone asks for it. I know there's a few that use vite-plugin-svelte with svelte.config.mjs but SvelteKit can have different constraints.

Should we also adjust svelte.dev to show the TS version of the config file? We currently don't https://github.com/sveltejs/svelte.dev/blob/9956e562430c0a089ce49a9864b86eab37cffb56/packages/site-kit/src/lib/markdown/renderer.ts#L375-L376

Still trying to think of other places we need to apply these TS updates to. Don't think we can switch the config file to TS in the SvelteKit TS template yet because people might still be using older Node versions.

I think we should land support in language-tools first and then document it with a note that it requires node24 or 22 with a flag.

There's also an open question of where to get the config type from. Kit exports it here

with sveltekit

import type {Config} from '@sveltejs/kit'
export default {/*...*/} satisfies Config

without sveltekit

import type {SvelteConfig} from '@sveltejs/vite-plugin-svelte'
export default {/*...*/} satisfies SvelteConfig

?

It might be good if sveltekits config type extended vite-plugin-sveltes 🤔 right now they differ slightly.

It might be good if sveltekits config type extended vite-plugin-sveltes 🤔 right now they differ slightly.

Oh, totally. That sounds like a good idea.

EDIT: started a PR here #13982