fix: correctly deserialize on the server#13686
Merged
dummdidumm merged 8 commits intomainfrom Jun 4, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: f9b2bd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
While this works, I'm wondering if this could introduce inconsistencies since you might expect that the decoders you defined will be used, but on the server they don't exist, i.e. will be ignored. |
Member
Author
|
I've updated |
Merged
sidharthv96
added a commit
to sidharthv96/kit
that referenced
this pull request
Jun 14, 2025
* main: (533 commits) Version Packages (sveltejs#13885) fix: sequential focus navigation starting point regression and hash routing (sveltejs#13884) feat: Respect abort signals during serverside fetch optimization (sveltejs#13877) fix: correct link to locals (sveltejs#13870) chore(deps): update pnpm to v10.12.1 (sveltejs#13876) chore: update Vitest to 3.2.3 (sveltejs#13865) Version Packages (sveltejs#13872) fix: correctly access `app.decoders` in inline and single output apps (sveltejs#13871) chore(deps): update dependency @netlify/functions to v4 (sveltejs#13838) Version Packages (sveltejs#13854) chore(deps): update pnpm to v10.12.1 (sveltejs#13849) fix: avoid setting sequential focus navigation starting point when using hash router (sveltejs#13861) fix: hash link to new page focuses the correct element (sveltejs#10856) fix: ensure `redirect` used in packages uses the same `Redirect` instance (sveltejs#13843) fix: include components dynamically imported in the universal load function when inlining CSS (sveltejs#13723) fix: correctly invalidate static analysis cache of child nodes during dev (sveltejs#13793) fix: suppress console spam for chrome devtools requests (sveltejs#13830) fix: correctly deserialize on the server (sveltejs#13686) fix: handle non-semver-style dependency versions (sveltejs#13850) Attempt to clarify use:enhance docs (sveltejs#13819) ...
Copilot AI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
fixes sveltejs#13675 This PR adds an optional chain for when deserialize tries to access app.decoders since app is always undefined on the server and is only initialised on the client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13675
This PR adds an optional chain for when
deserializetries to accessapp.decoderssinceappis alwaysundefinedon the server and is only initialised on the client.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits