Fix correct CStr pointer type#2
Merged
Merged
Conversation
Owner
|
Thank you! It’s more appropriate to clarify the semantics here. |
Contributor
Author
|
It is a bit unfortunate that the rustdoc documentation is always built for a specific platform. If you check https://doc.rust-lang.org/std/ffi/struct.CStr.html#method.from_ptr for example, it says i8 - not c_char. So it is really easy to make this mistake. |
Contributor
Author
|
To find the right type, you'd need to check the source using the link next to the method. |
Owner
|
Thank you for your pr, I learned a lot. |
8 tasks
singhc7
added a commit
to singhc7/nixpkgs
that referenced
this pull request
May 10, 2026
Fixes build on aarch64-linux. Upstream v1.0.0 corrected c_char pointer casts that hardcoded i8 instead of the target-portable c_char type (suyulin/afptool-rs#2). Upstream v1.2.3 also updates the integration test assertions to match current clap output (suyulin/afptool-rs#11), so the previous checkFlags workaround is no longer needed. Part of ZHF: NixOS#516381
singhc7
added a commit
to singhc7/nixpkgs
that referenced
this pull request
May 18, 2026
Fixes build on aarch64-linux. Upstream v1.0.0 corrected c_char pointer casts that hardcoded i8 instead of the target-portable c_char type (suyulin/afptool-rs#2). Upstream v1.2.3 also updates the integration test assertions to match current clap output (suyulin/afptool-rs#11), so the previous checkFlags workaround is no longer needed. Part of ZHF: NixOS#516381
singhc7
added a commit
to singhc7/nixpkgs
that referenced
this pull request
May 18, 2026
Fixes build on aarch64-linux. Upstream v1.0.0 corrected c_char pointer casts that hardcoded i8 instead of the target-portable c_char type (suyulin/afptool-rs#2). Upstream v1.2.3 also updates the integration test assertions to match current clap output (suyulin/afptool-rs#11), so the previous checkFlags workaround is no longer needed. Part of ZHF: NixOS#516381
coolcuber
pushed a commit
to coolcuber/nixpkgs
that referenced
this pull request
May 18, 2026
Fixes build on aarch64-linux. Upstream v1.0.0 corrected c_char pointer casts that hardcoded i8 instead of the target-portable c_char type (suyulin/afptool-rs#2). Upstream v1.2.3 also updates the integration test assertions to match current clap output (suyulin/afptool-rs#11), so the previous checkFlags workaround is no longer needed. Part of ZHF: NixOS#516381
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On aarch64 this would be u8, not i8.