Add different error handling behaviors for disk writing errors#75
Merged
sushichop merged 1 commit intosushichop:mainfrom Jan 29, 2023
Merged
Add different error handling behaviors for disk writing errors#75sushichop merged 1 commit intosushichop:mainfrom
sushichop merged 1 commit intosushichop:mainfrom
Conversation
For example when logging during a low disk space scenario it may be preferable to lose logs over crashing the app.
sushichop
approved these changes
Jan 29, 2023
Owner
|
@KaiOelfke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using Puppy during debugging a low disk space scenario. One crash was actually a side effect of logging with Puppy. The disk write failed due to low disk space. Using force trying to log is not always the right behavior for each logging use case.
For this scenario it's better to potentially lose some logs than to crash the app.
This PR adds two more error handling strategies for disk writes. There may be other valid error handling strategies.
assertionFailureto stop execution for debug builds and ignores failures in release buildsThe default option force has the current behavior. So this shouldn't be a breaking change, but allows Puppy users to pick a different behavior, when useful.