READY: feat(bigtable): introduce prime() method and load counting based on unary,streaming and ability to remove connection#1
Merged
Conversation
igorbernstein2
left a comment
There was a problem hiding this comment.
Lgtm, but I want @nimf to take a pass as well
nimf
approved these changes
Nov 13, 2025
| break // Normal stream end. | ||
| } | ||
| t.Fatalf("RecvMsg failed unexpectedly while draining: %v", err) | ||
| if err := stream.RecvMsg(&testpb.SimpleResponse{}); err == io.EOF { |
Collaborator
There was a problem hiding this comment.
the test will hang if for any reason it will be a different error
Owner
Author
There was a problem hiding this comment.
let me fix this on a different one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
2. Start all conns in a goroutine (make it parallel rather than sequential).