Changes for issue (Reduce complexity when parsing content #14)#15
Merged
supitsdu merged 1 commit intosupitsdu:mainfrom Jun 24, 2024
Merged
Changes for issue (Reduce complexity when parsing content #14)#15supitsdu merged 1 commit intosupitsdu:mainfrom
supitsdu merged 1 commit intosupitsdu:mainfrom
Conversation
Contributor
|
I reviewed the commit instead of the PR 🤦 |
Contributor
|
Fixes #14 |
Contributor
|
I should have been clearer, they were things I reported on the commit Let me review there |
ccoVeille
reviewed
Jun 24, 2024
supitsdu
pushed a commit
that referenced
this pull request
Jun 24, 2024
Extracted Content Parsing Logic: The parseContent function handles the logic of determining the content string based on the directText flag and file arguments. Simplified Main Function: The main function is now more concise, focusing on flag parsing, calling parseContent, and handling the result. Error Handling: The error handling is streamlined, with errors being returned from parseContent and handled in the main function.
This was referenced Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@supitsdu
Code changes include:
Extracted Content Parsing Logic: The parseContent function handles the logic of determining the content string based on the directText flag and file arguments.
Simplified Main Function: The main function is now more concise, focusing on flag parsing, calling parseContent, and handling the result.
Error Handling: The error handling is streamlined, with errors being returned from parseContent and handled in the main function.