Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThese changes introduce Nintendo-specific descrambling support for Blu-ray media by adding a boolean Changes
Sequence DiagramsequenceDiagram
participant Media as Media Input
participant Pipeline as Processing Pipeline
participant DF as DataFrame
participant Scrambler as Scrambler
participant SeedGen as Seed Generator
Media->>Pipeline: Detect Nintendo header
activate Pipeline
Pipeline->>Pipeline: Check physical data header<br/>(4-byte prefix & zero check)
Pipeline->>DF: Pass nintendo flag to descramble()
activate DF
DF->>Scrambler: descramble(data, lba, nintendo)
activate Scrambler
Scrambler->>SeedGen: Conditional branch on nintendo flag
activate SeedGen
alt Nintendo Path
SeedGen->>SeedGen: seedNintendo(lba)<br/>Multi-field bit manipulation
else Blu-ray Path
SeedGen->>SeedGen: seedBluray(lba)<br/>(lba + 0x100000) >> 5
end
deactivate SeedGen
Scrambler->>Scrambler: process(data, seed)<br/>Initialize shift_register with seed
deactivate Scrambler
DF->>DF: Validate descrambled data via EDC
deactivate DF
Pipeline->>Media: Output descrambled data
deactivate Pipeline
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@dvd/dvd_split.ixx`:
- Around line 268-274: The Nintendo auto-detect treats an emptied buffer as "all
zeros" after strip_response_header; to fix, after calling
read_vector(physical_path) and strip_response_header(physical) add a guard
ensuring physical is not empty (e.g., check !physical.empty()) before evaluating
std::all_of(physical.begin(), physical.end(), ...) so truncated / too-short
.physical payloads do not trigger the nintendo = true path; refer to the symbols
read_vector, strip_response_header, physical (the vector), std::all_of and the
nintendo variable when making the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6d69b7bb-b084-4b79-b6ae-673d3addda96
📒 Files selected for processing (4)
dvd/bd.ixxdvd/bd_scrambler.ixxdvd/dvd_dump.ixxdvd/dvd_split.ixx
Comment on lines
+268
to
+274
| bool nintendo = false; | ||
| if(std::filesystem::exists(physical_path)) | ||
| { | ||
| auto physical = read_vector(physical_path); | ||
| strip_response_header(physical); | ||
| if(std::all_of(physical.begin(), physical.end(), [](uint8_t b) { return b == 0x00; })) | ||
| nintendo = true; |
Contributor
There was a problem hiding this comment.
Guard the Nintendo auto-detect against empty .physical payloads.
On Line 272, strip_response_header() clears the buffer when the file is shorter than the 4-byte header. Line 273 then treats that empty range as “all zeros”, so a truncated .physical file flips the whole split path onto the Wii U seed algorithm.
💡 Proposed fix
auto physical = read_vector(physical_path);
strip_response_header(physical);
- if(std::all_of(physical.begin(), physical.end(), [](uint8_t b) { return b == 0x00; }))
+ if(!physical.empty() && std::all_of(physical.begin(), physical.end(), [](uint8_t b) { return b == 0x00; }))
nintendo = true;🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@dvd/dvd_split.ixx` around lines 268 - 274, The Nintendo auto-detect treats an
emptied buffer as "all zeros" after strip_response_header; to fix, after calling
read_vector(physical_path) and strip_response_header(physical) add a guard
ensuring physical is not empty (e.g., check !physical.empty()) before evaluating
std::all_of(physical.begin(), physical.end(), ...) so truncated / too-short
.physical payloads do not trigger the nintendo = true path; refer to the symbols
read_vector, strip_response_header, physical (the vector), std::all_of and the
nintendo variable when making the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Improvements