systems/gc.ixx (1)

1-6: Unused #include <sstream>.

<sstream> is included but no std::stringstream or related type is used in this file. The output goes directly to the std::ostream &os parameter.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@systems/gc.ixx` around lines 1 - 6, Remove the unused include for <sstream>
from the module header — the file currently includes <sstream> but only uses
std::ostream &os (and no stringstream or related types), so delete the "#include
<sstream>" line to avoid an unnecessary dependency; verify compilation and that
no other symbols from <sstream> are referenced in this translation unit (look
for the include near the top with module; and alongside <format>, <string>,
<vector>, "system.hh").

systems/wii.ixx (2)

1-6: Unused #include <sstream> (same as gc.ixx).

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@systems/wii.ixx` around lines 1 - 6, The file systems/wii.ixx includes
<sstream> but that header is unused (duplicate of gc.ixx); remove the stray
`#include` <sstream> line from systems/wii.ixx so only needed headers remain
(<format>, <string>, <vector>, "system.hh"), then rebuild to confirm no symbols
from std::stringstream are referenced anywhere in functions or classes in this
module.

---

19-72: Consider extracting shared logic between SystemGC and SystemWII.

The two classes are nearly identical in structure: same serial extraction, same title parsing, same disc_number logic, same Header layout (differing only in unknown size and magic fields). A shared base or template could reduce duplication, but this is optional given the files are small and self-contained.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@systems/wii.ixx` around lines 19 - 72, SystemWII duplicates much of
SystemGC's parsing/printing logic; refactor to extract the shared header parsing
and info printing into a common helper or base (e.g., a shared function
parse_and_print_wii_gc_header or a BaseDiscSystem class) that both SystemWII and
SystemGC call from their printInfo implementations; move common symbols/logic
(serial extraction using normalize_string, title parsing using
erase_all/std::string handling, disc_number check, and the shared parts of
struct Header layout) into that helper while keeping per-system differences
(getName(), getType(), magic constants and any differing Header field sizes) in
each subclass, and update SystemWII::printInfo and SystemGC::printInfo to
delegate to the new shared routine.

dvd/dvd_split.ixx (1)

169-169: Consider initializing nintendo_key.

nintendo_key is declared without initialization. Although it's guaranteed to be assigned at lba == 0 before use at lba == ECC_FRAMES - 1, leaving it uninitialized may trigger compiler warnings and hurts readability.

Suggested fix

-    std::uint8_t nintendo_key;
+    std::uint8_t nintendo_key = 0;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@dvd/dvd_split.ixx` at line 169, nintendo_key is declared without an initial
value which can trigger warnings; initialize it where declared (e.g., set to 0
or a sentinel) to make intent clear and avoid uninitialized-use warnings—update
the declaration of std::uint8_t nintendo_key in dvd_split.ixx to include an
initializer (e.g., = 0) or switch to an optional-like type if you need an
explicit "unset" state.

dvd/dvd_split.ixx (1)

168-175: nintendo_key is declared without initialization.

If nintendo is true, nintendo_key is always set at lba == 0 before use at lba == ECC_FRAMES - 1, so this is safe in practice. Still, initializing it avoids warnings from static analyzers and makes the intent clearer.

Proposed fix

     bool nintendo = false;
-    uint8_t nintendo_key;
+    uint8_t nintendo_key = 0;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@dvd/dvd_split.ixx` around lines 168 - 175, The variable nintendo_key is
declared without initialization which triggers static analyzer warnings;
initialize it when declared (e.g., set uint8_t nintendo_key = 0) in the
dvd_split.ixx snippet alongside the existing bool nintendo declaration so that
nintendo_key has a defined value before any conditional assignment/use
(references: nintendo_key, nintendo, and the related lba/ECC_FRAMES usage in the
same file).