Skip to content

reverted to --rings option, removed desync stats#342

Merged
superg merged 1 commit intomainfrom
remove_desync_stats
Feb 5, 2026
Merged

reverted to --rings option, removed desync stats#342
superg merged 1 commit intomainfrom
remove_desync_stats

Conversation

@superg
Copy link
Owner

@superg superg commented Feb 4, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features
    • Added --rings command-line option to enable filesystem-based rings detection. The rings command will automatically execute when this option is enabled.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The changes introduce a new --rings command-line option to the Options struct, update command-line parsing and help text to support this flag, conditionally insert the "rings" command into the redumper command list when enabled, and remove subcode desync statistics logging from cd_common.ixx.

Changes

Cohort / File(s) Summary
Subcode Logging Removal
cd/cd_common.ixx		 Removed 4 lines of logging output for subcode desync statistics inside subcode_load_subpq; underlying desync detection logic remains intact.
Rings Option Introduction
options.ixx, redumper.ixx		 Added new boolean rings option to Options struct with command-line parsing (--rings flag) and help text. Redumper now conditionally prepends "rings" command to the default CD operation command list when options.rings is true.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • Dreamcast support #322: Directly related—both PRs modify rings option handling and command assembly in options.ixx and redumper.ixx, touching the same code paths.

Poem

🐰✨ A rings option hops along,
CLI flags now strong and long,
Command lists dance with conditions true,
New detection paths emerge for you! 🎪

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two main changes: reverting the --rings option and removing desync statistics logging.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove_desync_stats

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@superg superg merged commit ad74128 into main Feb 5, 2026
11 checks passed
Deterous added a commit to Deterous/redumper that referenced this pull request Feb 5, 2026
@Deterous @Sazpaimon
@superg @coderabbitai
superg changes (#17)
3afe9a9 
* Skip all sectors after a subcode desync instead of just the first (superg#341)

* Initial OmniDrive support (superg#336) (superg#340)

* Initial OmniDrive support (superg#336)

* Initial OmniDrive support

* Count SCSI errors in dumpable range during refine

* Initial Xbox support

* Raw BD support

* revert bd

* revert one more

* Code review

* changed dvd scrambler table init to construction (temporary?)

* revert code that will come in other PRs

* refactoring

* rework drive info output

* recording/data frame conversion, dvd dump loop refactored

* Apply suggestions from code review

CR feedback

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* added parity generation

* commonize overread count, dvd overread configuration, PSN refactoring

* chunk refactoring, addressed CR review

* removed unnecessary code

* addressed CR issue

---------

Co-authored-by: Deterous <138427222+Deterous@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* reverted to --rings option, removed desync stats (superg#342)

---------

Co-authored-by: Sazpaimon <sazpaimon@x-cult.org>
Co-authored-by: Hennadiy Brych <gennadiy.brich@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@superg superg deleted the remove_desync_stats branch February 28, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@superg