Fix double content bug in thread logging#237
Merged
drbrady8800 merged 1 commit intomainfrom Jun 20, 2025
Merged
Conversation
scottpersinger
approved these changes
Jun 18, 2025
Collaborator
scottpersinger
left a comment
There was a problem hiding this comment.
looks good. I really think eventually we will want to store our Events natively, which we are close to, and reconstruct chat history from them (rather than storing LLM "messages"). When we do this this log function should look really simple.
ritzz26
pushed a commit
that referenced
this pull request
Jun 23, 2025
ritzz26
pushed a commit
that referenced
this pull request
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PromptStartedevents were getting logged like this: `{"content": {"content": "actual prompt"}} which was surfaced with Scott's recent changes to loading chat history into the state. This addresses that and also allows for logs to be viewed even if the bug affects them.