Fix Run Script toolbar dropdown caching scripts from first-opened repo#283
Merged
Fix Run Script toolbar dropdown caching scripts from first-opened repo#283
Conversation
#280) The Menu inside ToolbarItem reused the NSMenu items captured the first time it was opened, so switching repositories kept showing the original repo's scripts. Keying the ScriptMenu by rootURL forces a fresh menu per repo; a nil transaction suppresses the insert/remove animation that the id swap would otherwise trigger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #280.
Summary
MenuinsideToolbarItemwas reusing the NSMenu items captured the first time it was opened, so every repo afterward kept showing the original repo's scripts.ScriptMenubyrootURLso SwiftUI rebuilds it per repo, and added a nil-animation transaction to suppress the insert/remove transition the id swap would otherwise trigger.Test plan