Merged
Conversation
`⌘⇧,` (ghostty's `reload_config`) did nothing in Supacode because the surface view forwarded every consumed ghostty binding to `NSApp.mainMenu.performKeyEquivalent` wholesale, which can intercept ghostty-only shortcuts. Now only forward when an item actually matches key + modifier mask (with implicit-shift handling for uppercase keyEquivalent). Fixes #240.
jzillmann
pushed a commit
to jzillmann/supacool
that referenced
this pull request
Apr 23, 2026
…abitapp#259) `⌘⇧,` (ghostty's `reload_config`) did nothing in Supacode because the surface view forwarded every consumed ghostty binding to `NSApp.mainMenu.performKeyEquivalent` wholesale, which can intercept ghostty-only shortcuts. Now only forward when an item actually matches key + modifier mask (with implicit-shift handling for uppercase keyEquivalent). Fixes supabitapp#240.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
⌘⇧,(ghostty'sreload_config) did nothing in Supacode: the surface view forwarded every consumed ghostty binding toNSApp.mainMenu.performKeyEquivalentwholesale, which can intercept ghostty-only shortcuts via AppKit's menu matching quirks.keyEquivalent).Test plan
~/.config/ghostty/config(e.g. changefont-size), press⌘⇧,in a focused terminal surface → surfaces redraw with the new config without restarting the app.⌘,still opens Settings.⌘Tnew tab,⌘Wclose surface) still work.make testpasses.Closes #240