Skip to content

Improve open worktree UX with dedicated Reveal in Finder#247

Merged
sbertix merged 1 commit intomainfrom
sbertix/better-open
Apr 15, 2026
Merged

Improve open worktree UX with dedicated Reveal in Finder#247
sbertix merged 1 commit intomainfrom
sbertix/better-open

Conversation

@sbertix
Copy link
Copy Markdown
Collaborator

@sbertix sbertix commented Apr 15, 2026

Summary

  • Separate "Reveal in Finder" (⌥⌘R) from the primary "Open Worktree" (⌘O) action so each has its own shortcut and toolbar/menu presence
  • Add context menu open actions for worktrees with primary open, "Open With" submenu, and "Reveal in Finder"
  • Rename .openFinder shortcut ID to .openWorktree with backward-compatible settings migration
  • Extract shared openWorktreeEffect helper with OpenWorktreeSource enum for analytics tracking (toolbar vs contextMenu vs revealInFinder)
  • Add consistent appLogger.warning(...) on all worktree lookup guards

Test plan

  • 736 tests pass (9 new open-worktree tests, 2 new shortcut migration tests, 1 new settings test)
  • Analytics source parameter verified for all 3 code paths
  • Backward-compat "openFinder" decode → .openWorktree tested
  • Toolbar primary button guards against .finder fallback
  • Build succeeds with 0 errors

Separate "Reveal in Finder" from the primary open action so users get
a dedicated shortcut (⌥⌘R) for Finder while the main shortcut (⌘O)
opens with their preferred app. Add context menu open actions for
worktrees, extract shared openWorktreeEffect helper with analytics
source tracking, and add consistent warning logs on all worktree
lookup guards.
@sbertix sbertix force-pushed the sbertix/better-open branch from ea52a2f to 725b83a Compare April 15, 2026 14:12
@tuist
Copy link
Copy Markdown

tuist Bot commented Apr 15, 2026

🛠️ Tuist Run Report 🛠️

Builds 🔨

Scheme Status Duration Commit
supacode 1m 3s 4ff37f5a0

@sbertix sbertix merged commit bdba751 into main Apr 15, 2026
2 checks passed
@sbertix sbertix deleted the sbertix/better-open branch April 15, 2026 17:24
Whoaa512 added a commit to Whoaa512/supacode that referenced this pull request Apr 16, 2026
* fix/unfocused-split-opacity: (24 commits)
  add xcbeautify to mise.toml so local builds work without separate install
  install dev build as supacode-dev.app to coexist with homebrew install
  ignore legacy Ghostty build outputs
  work around Xcode 26.4 local builds
  Respect unfocused-split-opacity from Ghostty config
  Add multiple user-defined scripts per repository (supabitapp#246)
  Respect ghostty split-preserve-zoom config when cycling splits (supabitapp#241)
  Improve open worktree UX and rename openFinder to openWorktree (supabitapp#247)
  Add RubyMine editor support (supabitapp#248)
  fix(ci): skip tuist auth on fork pull requests
  stuff
  Align trailing comma tooling
  cache
  Split dependency inspection CI
  Switch Tuist CI auth to OIDC
  simplify build output formatting
  simplify app tuist dependencies
  simplify tuist package linkage
  restore required tuist package overrides
  remove package framework search paths
  ...

# Conflicts:
#	supacode/Features/Repositories/Views/WorktreeRow.swift
#	supacode/Features/Repositories/Views/WorktreeRowsView.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant