docs: Add Deno how-to to README.md#956
Merged
Merged
Conversation
mansueli
approved these changes
Jan 23, 2024
J0
approved these changes
Jan 23, 2024
mandarini
pushed a commit
that referenced
this pull request
Oct 2, 2025
## What kind of change does this PR introduce? Bug fix for the TypeScript types. ## What is the current behavior? - Fixes supabase/auth-js#955 ## What is the new behavior? Use [TypeScript's function overloading](https://www.typescriptlang.org/docs/handbook/2/functions.html#function-overloads) to return - TOTP data when `mfa.enroll` was passed `factorType: 'totp'`, - phone data when `mfa.enroll` was passed `factorType: 'phone'`. This fixes a breaking change in the types in 72c60f4. ## Additional context This PR would also expose the new following types: - `MFAEnrollTOTPParams` - `MFAEnrollPhoneParams` - `AuthMFAEnrollTOTPResponse` - `AuthMFAEnrollPhoneResponse` - `AuthMFAEnrollErrorResponse` (it might be better to roll this type in with the other two). It might be better to keep these types private, since once they're exposed, you can't easily remove them again without creating a breaking change.
mandarini
pushed a commit
that referenced
this pull request
Oct 2, 2025
## What kind of change does this PR introduce? Follow up to #956, hides the MFA sub-types (e.g. MFA Phone, MFA TOTP) needed to fix type errors before we release to public so that we can remove them as and when we like. The sub-types are now stored in an `internal-types` file which, unlike the `types` file is not exposed to public. The types mentioned here have not been released yet so fine to hide them
mandarini
pushed a commit
that referenced
this pull request
Oct 2, 2025
🤖 I have created a release *beep* *boop* --- ## [2.65.1](supabase/auth-js@v2.65.0...v2.65.1) (2024-10-14) ### Bug Fixes * Call `SIGNED_OUT` event where session is removed ([#854](supabase/auth-js#854)) ([421d7d4](supabase/auth-js@421d7d4)) * improve `mfa.enroll` return types ([#956](supabase/auth-js#956)) ([aca7870](supabase/auth-js@aca7870)) * move MFA sub types to internal file ([#964](supabase/auth-js#964)) ([70cecdb](supabase/auth-js@70cecdb)) * remove phone mfa deletion, match on error codes ([#963](supabase/auth-js#963)) ([3547cd9](supabase/auth-js@3547cd9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deno usage how-to.